Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel: T6866: IPv6 distribute-lists in access-list6 format have names not numbers #4187

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Nov 11, 2024

Change Summary

Add missing smoketests for babel routing protocol. In addition refactor the XML include definitions to avoid re-use of XML statements for both IPv4 and IPv6 route redistribution.

IPv4 EIGRP route redistribution was added by accident as there is no working EIGRP implementation yet - drop it from CLI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

FRR/babeld

Smoketest result

test_babel_basic (__main__.TestProtocolsBABEL.test_babel_basic) ... ok
test_babel_distribute_list (__main__.TestProtocolsBABEL.test_babel_distribute_list) ... ok
test_babel_interfaces (__main__.TestProtocolsBABEL.test_babel_interfaces) ... ok
test_babel_redistribute (__main__.TestProtocolsBABEL.test_babel_redistribute) ... ok

----------------------------------------------------------------------
Ran 4 tests in 17.194s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Nov 11, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po changed the title babel: T4977: add missing smoketests babel: T6866: IPv6 distribute-lists in access-list6 format have names not numbers Nov 11, 2024
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@dmbaturin dmbaturin merged commit d51765c into vyos:current Nov 13, 2024
14 of 16 checks passed
@c-po c-po deleted the babel-tests branch November 17, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants