utils: T7095: make vrf
and netns
arguments aware of the shell
#4323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Changes the
vrf
andnetns
functionality in the utils/process.py to be aware of whether the shell is required or not. Fixes a regression they introduced that broke callers passing a list rather than a string to the popen (and family) of util functions, notably breaking the git commit-archive functionality.I also removed the
auth
parameter as it was not fully implemented, was not used, was not documented, and I could not find any examples of the form it would take, making it difficult to integrate into the refactor.Types of changes
Related Task(s)
https://vyos.dev/T7095
Bug introduced in https://vyos.dev/T6975
Related PR(s)
How to test / Smoketest result
Prior to this patch, the commit-archive will fail with an error similar to the following.
After this change the functionality works again.
Checklist: