Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some spell mistakes #1247

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Fix some spell mistakes #1247

merged 9 commits into from
Jan 19, 2024

Conversation

sebweb3r
Copy link
Contributor

Hey,

I stumbled upon some typos and started fixing them.
Is such a contribution welcome? Should I make smaller commits or do you favor bigger ones?

Best regards,

Sebastian

@rebortg
Copy link
Member

rebortg commented Jan 19, 2024

Hey,
yes this kind of contribution is very welcome. Smaller commits are better, a lot of these changes should be also done in the sagitta branch. a single file PR is better to cherry-pick as a large PR.

@rebortg rebortg merged commit 4a02bcc into vyos:master Jan 19, 2024
4 of 5 checks passed
@rebortg
Copy link
Member

rebortg commented Jan 19, 2024

@Mergifyio backport sagitta

Copy link

mergify bot commented Jan 19, 2024

backport sagitta

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants