docker: Multiple fixes #1392
Merged
docker: Multiple fixes #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebortg
requested changes
May 8, 2024
There was a problem hiding this comment.
Did you test the build and usage? I Build this on Mac but got an error when i want to build the docu:
docker run --rm -it -v "$(pwd)":/vyos -w /vyos/docs \
-e GOSU_UID=$(id -u) -e GOSU_GID=$(id -g) vyos-docsv2 make html
Current UID/GID: 501/20
sudo: exec: command not found
|
@rebortg I did test it at the time, but for some reason it isn't working now. I've added another commit to fix the issue, tested working on macOS 14.4.1. |
|
@MattKobayashi can you please add a comment why |
|
@c-po That's correct, macOS UIDs begin at 501. This is actually part of the Linux Standard Base specification. |
c-po
reviewed
May 10, 2024
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
1 task
c-po
added a commit
that referenced
this pull request
May 10, 2024
docker: Multiple fixes (backport #1392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
--break-system-packagesoption topip3 installcommandchmod a+sfrom Dockerfile (newer versions ofgosuin particular don't support this)sudoto relevant commands inentrypoint.shUID_MINkey toaddusercommand (allows the container to run on MacOS)Related Task(s)
Related PR(s)
Backport
Checklist: