Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T7076: VPP check ethernet interface exist #6

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

natali-rs1985
Copy link

@natali-rs1985 natali-rs1985 commented Jan 28, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-1x#4327

Proposed changes

How to test

vyos@vyos# ls /sys/class/net/
dum0  eth0  eth1  eth2  eth3  lo  pim6reg
[edit]
vyos@vyos# set vpp settings interface dum0

  Error: dum0 is not an ehternet interface



  Invalid interface name
  Value validation failed
  Set failed

[edit]
vyos@vyos# set vpp settings interface eth99

  Error: eth99 does not exist in the system



  Invalid interface name
  Value validation failed
  Set failed

[edit]
vyos@vyos# set vpp settings interface eth1
[edit]
vyos@vyos#

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

src/conf_mode/vpp.py Outdated Show resolved Hide resolved
src/conf_mode/vpp.py Outdated Show resolved Hide resolved
@natali-rs1985 natali-rs1985 changed the title T7076: VPP check ethernet interface exist before adding to vpp T7076: VPP check ethernet interface exist Jan 30, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the constaint to only allow ethernet interfaces.

@natali-rs1985
Copy link
Author

Please limit the constaint to only allow ethernet interfaces.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants