Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T0000: pr comment #28

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/add-pr-cmt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Add pull request Cmt

on:
pull_request_target:
pull_request:
branches:
- current

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-unused-imports.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Check for unused imports using Pylint
on:
pull_request:
pull_request_target:
branches:
- current

Expand Down
1 change: 1 addition & 0 deletions src/tests/test_configverify.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from unittest import TestCase
import json

Check failure on line 18 in src/tests/test_configverify.py

View workflow job for this annotation

GitHub Actions / ruff-lint

Ruff (F401)

src/tests/test_configverify.py:18:8: F401 `json` imported but unused
from vyos.configverify import verify_diffie_hellman_length
from vyos.utils.process import cmd

Expand Down
1 change: 1 addition & 0 deletions src/tests/test_dict_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

from unittest import TestCase
import json

Check failure on line 18 in src/tests/test_dict_search.py

View workflow job for this annotation

GitHub Actions / ruff-lint

Ruff (F401)

src/tests/test_dict_search.py:18:8: F401 `json` imported but unused
from vyos.utils.dict import dict_search
from vyos.utils.dict import dict_search_recursive

Expand Down Expand Up @@ -45,7 +46,7 @@
def test_non_existing_keys(self):
# TestDictSearch: Return False when querying for non-existent key
self.assertEqual(dict_search('non_existing', data), None)
if False: print('False')

Check failure on line 49 in src/tests/test_dict_search.py

View workflow job for this annotation

GitHub Actions / ruff-lint

Ruff (E701)

src/tests/test_dict_search.py:49:17: E701 Multiple statements on one line (colon)
self.assertEqual(dict_search('non.existing.fancy.key', data), None)

def test_string(self):
Expand Down
Loading