Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum_types::U256
is basically the same asprimitive_types::U256
but later on it will allow you to#[derive(Deserialize)]
directly from the json. I spent a lot of time learning how serde worked & trying to build around the fact thatprimitive_types::U256
couldn't do this and.. well, eventually gave up. Rust doesn't make that kind of work around trivial (afaict..)my original solution used
Option<String>
everywhere and it obviously makes the code significantly uglier / harderlmk if you want to chat more about any of the other changes but think the rest are more straightforward