Remove incorrect sentence about explicit root observers #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What that paragraph is trying to say is that all targets of an explicit-root observer are defined by the spec as "same-origin-domain" targets. The relationship with the top-level origin is only relevant for implicit-root observers. Feel free to fix this PR, or I will put up a separate one. |
szager-chromium
added a commit
that referenced
this pull request
Apr 11, 2022
|
Closing this in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @szager-chromium the other day, the sentence that I'm removing in this PR is incorrect. A target of an explicit root observer certainly does not have to be a same-origin-domain target, because you can provide an explicit root in cross-origin subframes, but in said subframes the target's setting's object's origin is of course cross-origin with that of the top-level one.
Preview | Diff