-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usages of module fetching html algorithms #1658
base: main
Are you sure you want to change the base?
Update usages of module fetching html algorithms #1658
Conversation
Ms2ger marked as non substantive for IPR from ash-nazg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although I don't have merge rights, I hope the editors can merge this soon.
They should delay until ~24 hours from now to make sure the HTML exported definitions get indexed.
I checked the diff and found that there is one instance of "Asynchronously complete these steps" (in the clause "If maxScopeString is null or scopeString does not start with maxScopeString, then:") which is not replaced with "Invoke processCustomFetchResponse". |
Thanks @triple-underscore, updated! |
Please don't merge this yet, until whatwg/html#8412 is merged. |
@yoshisatoyanagisawa now that you are active, it would be great to get this merged :) |
Hi! I recently become an editor and am happy to review the PR :) |
Yes, I'll get to it next week. |
This updates this spec for whatwg/html#8264 and whatwg/html#8328.
Preview | Diff