Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Color 5 2022-05-20 > 2022-08-20 #29

Closed
svgeesus opened this issue May 20, 2022 · 17 comments
Closed

CSS Color 5 2022-05-20 > 2022-08-20 #29

svgeesus opened this issue May 20, 2022 · 17 comments
Labels
LC Working Draft approaching Candidate Recommendation REVIEW REQUESTED

Comments

@svgeesus
Copy link

Other comments:

CSS WG would like to draw your attention in particular to the color-contrast() function which automatically calculates the color (from a list of candidate colors) with the highest WCAG 2.1 luminance contrast.

CSS WG is aware of the existing work to produce a better contrast metric; applauds this work, and hopes to reference it as an option in the color-contrast() function when consensus has formed and the calculation has stabilized. Meanwhile though, and despite the known limitations of the WCAG 2.1 luminance contrast formula, this is the one we are referencing for now.

@svgeesus svgeesus added LC Working Draft approaching Candidate Recommendation REVIEW REQUESTED pending This issue needs to get a reviewer assigned to it labels May 20, 2022
@michael-n-cooper
Copy link
Member

@michael-n-cooper michael-n-cooper removed the pending This issue needs to get a reviewer assigned to it label Jun 1, 2022
@svgeesus
Copy link
Author

svgeesus commented Jun 5, 2022

Note that a Formal Objection to CSS Color 4 color-contrast() referencing the W3C Recommendation WCAG 2.1 Color Contrast has been raised by @Myndex

For further details on possible resolution, please see
w3c/csswg-drafts#7297 (comment)

@svgeesus
Copy link
Author

Note that the color-contrast() function was moved to CSS Color 6, and thus no longer forms part of CSS Color 5. We believe this resolves the formal objection.

Are there any A11y comments on the rest of the specification?

We are trying to deal with all issues on this specification, in preparation for moving to CR.

@svgeesus
Copy link
Author

@Matatak ?

@Myndex
Copy link
Member

Myndex commented Aug 23, 2022

The only thing I'd like to mention, that we've been discussing in terms of making normative, is that any site that uses a color space other than sRGB must also support sRGB as a default.

I could see this expanded to "only sRGB and display P3".

The two biggest concerns for color spaces and accessibility are the position of the RED primary, and the dynamic range/mapping of the dynamic range related to text and semantic non-text content.

What I think this implies is the need for a media query such as "prefers sRGB"

or some means of fallback to sRGB values.

I also tend to think that at this time, it would be challenging to develop visual accessibility guidelines that accurately encompassed the breadth of color spaces permitted in CSS 5, and arguably, accessibility guidelines are best constrained to cases that relate to physically realizable display tecnologies.

@svgeesus
Copy link
Author

accessibility guidelines are best constrained to cases that relate to physically realizable display tecnologies.

I think some confusion exists here; for accessibility, what matters is the display. For specifying color, it is perfectly fine to have imaginary primaries like ProPhoto or indeed CIE XYZ. These are quite separate concepts. There is no display on the market that takes OK L, a and b as inputs. But OKLab works great for things like computing color gradients.

This is why I would prefer to see APCA explicitly state that the equations are modelling a reference sRGB-like display and that Ys is the luminance of that display.

@Myndex
Copy link
Member

Myndex commented Aug 28, 2022

Hi Chris @svgeesus

I understand I may not be in touch with scope/context of this thread, so my further comments might not belong here, I'll be very brief:

This is why I would prefer to see APCA explicitly state that the equations are modelling a reference sRGB-like display and that Ys is the luminance of that display.

It does state this, BUT... as I think you have noticed I have a documentation problem that is an ongoing priority task among a lot of priority tasks... 😳

...for accessibility, what matters is the display...

So, what I have been considering lately is, for WCAG guidelines, a very simplified set of minimums, citing sRGB as the reference display (possibly adding in P3 as an option).

But then the more complete guidelines/system as a separate (not WCAG) guideline, as I outline in this post at the incubator: Visual Contrast and Readability methods and guidelines which would be a superset of the simplified minimums.

This might be a good discussion sometime for a zoom call...

@matatk
Copy link

matatk commented Sep 4, 2022

@svgeesus: APA has no accessibility concerns regarding the substance of CSS Color Module Level 5 (we reviewed the 2022-06-28 WD).

It's clear that a lot of effort has gone into making the document readable and understandable. However, we did notice some accessibility barriers, particularly from the perspective of readers who may struggle with color perception. These concerns, with suggestions, are being filed as issues on the CSSWG tracker.

We're aware that color-contrast() has been pushed back to Level 6. However, we were wondering what are the use cases for this function? The function selects from a pre-determined list of colours; are there situations in which the answer could not have been determined at design time? We don't feel that this function is required in order to further accessibility, but we're happy to provide any needed support in adding it, if you wish to add it or something similar in future. The color-contrast() function is on our agenda for TPAC and we'd be happy to learn more about, and discuss this more there.

APA WG consensus decision on this and our other comments

@svgeesus
Copy link
Author

svgeesus commented Sep 5, 2022

It's clear that a lot of effort has gone into making the document readable and understandable. However, we did notice some accessibility barriers, particularly from the perspective of readers who may struggle with color perception. These concerns, with suggestions, are being filed as issues on the CSSWG tracker.

Thanks for taking the time to point these out, I am going through and addressing them one by one.

@svgeesus
Copy link
Author

svgeesus commented Sep 5, 2022

We're aware that color-contrast() has been pushed back to Level 6.

Yes. Lets discuss that on an appropriately-tagged issue, so that the discussion does not get lost in this one. Happy to discuss at TPAC, also.

@michael-n-cooper
Copy link
Member

michael-n-cooper commented Sep 28, 2022

@michael-n-cooper
Copy link
Member

@AutoSponge
Copy link

I'm tracking this discussion as well as related discussions like w3c/csswg-drafts#7358

@AutoSponge
Copy link

We want to update AGWG about the ongoing conversation.

@svgeesus
Copy link
Author

A reminder that this issue is for A11y review of CSS Color 5 before it moves to CR.

The meta-issue for tracking the development of contrast-color(), which is in CSS Color 6, is here

@svgeesus
Copy link
Author

So, given there were no substantive comment on the specification, and the accessibility barriers (thanks for raising those issues) are all addressed, could this be closed @michael-n-cooper @matatk ?

@matatk
Copy link

matatk commented Feb 21, 2023

Agreed @svgeesus, this can be closed (I'm not able to, but if you are, you're welcome to.)

Thanks again for your quick fixes on the presentational accessibility issues we raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LC Working Draft approaching Candidate Recommendation REVIEW REQUESTED
Projects
None yet
Development

No branches or pull requests

6 participants