Update ERRATA.md #585
Open
Update ERRATA.md #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tantek
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
LGTM, verified https://www.w3.org/TR/activitystreams-vocabulary/#ex106-jsonld and added suggestion of linking "Example 102" in the PR accordingly for easier "follow-your-nose" discovery for readers of the Errata.
| @@ -80,3 +80,24 @@ This document includes errata for the [Activity Streams](https://www.w3.org/TR/a | |||
| - Unlike `latitude` and `longitude`, the domain of the `altitude` term is the `Object` type. The `altitude` term should be included in the list of properties of an `Object`. Because `altitude` is primarily documented as a property of a `Place`, publishers should not include `altitude` on objects that are not of type `Place`, and consumers should accept objects with this property that aren't of type `Place`. | |||
|
|
|||
| - The domain of the `attributedTo` property is both `Link` and `Object`. `attributedTo` should be included in the list of properties of a `Link`. | |||
|
|
|||
| - Example 102 is missing a `type` property on the `Link` value of the `url` property. For clarity, the example should read: | |||
There was a problem hiding this comment.
Suggested change
| - Example 102 is missing a `type` property on the `Link` value of the `url` property. For clarity, the example should read: | |
| - [Example 102](https://www.w3.org/TR/2017/REC-activitystreams-vocabulary-20170523/#ex106-jsonld) is missing a `type` property on the `Link` value of the `url` property. For clarity, the example should read: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #444 I've added an erratum to show what's potentially the correct value for the type in example 102.
There's some dispute about whether this example is strictly incorrect, and if therefore it's actually an editorial error that belongs in the ERRATA. It's definitely better form, and the lack of a type property is not the point of the example. I'll leave this open to the CG for advice or a decision.