Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Upgrade to ESLint 9 #3011

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Infrastructure: Upgrade to ESLint 9 #3011

merged 2 commits into from
Jul 31, 2024

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented May 2, 2024 •
edited by daniel-montalvo
Loading

Took a pass at converting to the new flat config and ESLint 9.

  • Dropped Prettier plugins and replaced the with updated globs
  • Hacked around Ava's plugin not officially supporting v9 yet
  • Prettier ignore for a conflicting formatting
  • Bump ES6 to ES2021 since it was already used by app.js

WAI Preview Link (Last built on Tue, 04 Jun 2024 18:52:32 GMT).

@daniel-montalvo daniel-montalvo mentioned this pull request May 2, 2024
Closed
@howard-e howard-e added Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation dependencies Pull requests that update a dependency file in a third-party package labels May 2, 2024
@howard-e howard-e self-requested a review May 7, 2024 14:08
@nschonni nschonni changed the title chore: Upgrade to ESLint 9 Infrastructure: Upgrade to ESLint 9 May 7, 2024
@nschonni
Copy link
Contributor Author

nschonni commented Jun 3, 2024

@howard-e I gave this a rebase for the conflicts

@howard-e
Copy link
Contributor

howard-e commented Jun 3, 2024 •
edited
Loading

Okay cool, thanks! Will review

@howard-e howard-e mentioned this pull request Jun 3, 2024
Closed
@nschonni
Copy link
Contributor Author

nschonni commented Jun 3, 2024

If you want to land other stuff, that's fine, just ping me if it gets a conflict

howard-e
howard-e reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Took a pass through the migration docs as well, thanks for tackling this!
Left small questions inline.

eslint.config.mjs Show resolved Hide resolved
eslint.config.mjs Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
@nschonni nschonni requested a review from howard-e June 11, 2024 05:56
howard-e
howard-e approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a pass at converting to the new flat config and ESLint 9.

@nschonni this is great, so much more than just a "pass" -- thanks!

@howard-e howard-e mentioned this pull request Jun 11, 2024
Closed
@howard-e howard-e merged commit 081e028 into w3c:main Jul 31, 2024
13 checks passed
@nschonni nschonni deleted the eslint9 branch July 31, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file in a third-party package Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nschonni @howard-e