prevent use of aria-hidden=true on document root elements #1880

scottaohara · 2023-03-03T13:38:06Z

adds user agent and author requirements regarding the use of aria-hidden=true on root-level elements of a document.

@cookiecrook I took a first stab at drafting up the author and UA must nots. Please revise however you see fit.

Related Core AAM Issue/PR:
Related AccName Issue/PR:
Related APG Issue/PR:
ARIA in HTML 447

Implementation tracking

@cookiecrook

closes #1254 @cookiecrook I took a first stab at drafting up the author and UA must nots. Please revise however you see fit.

cookiecrook

Great start. Raising some questions that I don't currently know the answer to. Thanks for taking this one on!

index.html

jcsteh

Thanks for working on this.

Does this conflict with #1256? That proposal has its own set of challenges, but as I understand it, it could be used to emulate dialog.showModal(). That is, an author might set aria-hidden=true on the root and then set aria-hidden=false on a (non-native) modal dialog.

I tend to think the risk of abuse with aria-hidden on the root is higher than the advantages of supporting the theoretical emulation of dialog.showModal(), but I know there's been some push to have parallel support in ARIA for native HTML features, which is why I'm raising it here.

Co-authored-by: James Craig <[email protected]>

scottaohara · 2023-03-24T17:54:22Z

thanks a ton for those edits, @cookiecrook

index.html

companion PR to w3c/aria#1880

https://bugs.webkit.org/show_bug.cgi?id=269523 rdar://123049663 Reviewed by Chris Fleizach. To prevent authors from hiding all content from assistive technologies, aria-hidden should not be respected on document root elements (`html`, `body`, or top-level `svg`s). w3c/aria#1880 * LayoutTests/accessibility/body-element-aria-hidden-expected.txt: Added. * LayoutTests/accessibility/body-element-aria-hidden.html: Added. * LayoutTests/accessibility/html-element-aria-hidden-expected.txt: Added. * LayoutTests/accessibility/html-element-aria-hidden.html: Added. * LayoutTests/platform/ios/TestExpectations: Enable new tests. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAHidden const): (WebCore::AccessibilityObject::tagName const): (WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::attributes const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::tagName const): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

https://bugs.webkit.org/show_bug.cgi?id=269523 rdar://123049663 Reviewed by Chris Fleizach. To prevent authors from hiding all content from assistive technologies, aria-hidden should not be respected on document root elements (`html`, `body`, or top-level `svg`s). w3c/aria#1880 * LayoutTests/accessibility/body-element-aria-hidden-expected.txt: Added. * LayoutTests/accessibility/body-element-aria-hidden.html: Added. * LayoutTests/accessibility/html-element-aria-hidden-expected.txt: Added. * LayoutTests/accessibility/html-element-aria-hidden.html: Added. * LayoutTests/platform/ios/TestExpectations: Enable new tests. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isARIAHidden const): (WebCore::AccessibilityObject::tagName const): (WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::attributes const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::tagName const): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: Canonical link: https://commits.webkit.org/277677@main

aleventhal

Hopefully it is clear to readers what a primary document is. Do we need to define that in the glossary or is it really obvious to the intended audience?

cookiecrook

@scottaohara, in an earlier comment you said the embedded view (iframe, img, etc) could be hidden by the containing context, so on a per-document level, this rule need not be aware of its embeddedness, or whether it's the "primary" document.

the root element or the host language element that represents the contents of the ~~primary~~ document in view.

I agree with you, so it's possible this ~"root element or the host language element representing contents" is sufficient without the undefined "primary document" term.

aleventhal · 2024-04-26T14:31:01Z

What if the parent document doesn't have as much context as the iframe's contents about whether it should be hidden or not? They might not even be from the same domain. Is it difficult for any of the implementations to determine whether the document is top level?

aleventhal

Removing my +1 until we get consensus on whether the top level document's documentElement/body is treated differently from the iframe's.

cookiecrook · 2024-04-26T17:14:45Z

Removing my +1 until we get consensus on whether the top level document's documentElement/body is treated differently from the iframe's.

If that's a deal-breaker for Aaron, I'd say let's keep "primary." It does allow more permissive authoring flexibility, albeit adding a bit more implementation complexity.

aleventhal · 2024-04-26T19:34:17Z

I think it just adds a single condition to the 'if' statement. Not too complex IMO. I'd rather not deal with the bug that gets filed with a legit use case. But perhaps Scott has a good reason to disallow in iframe html/body elements.

scottaohara · 2024-04-27T17:00:18Z

Allowing an html/body element to have aria-hidden=true on it in an iframe wouldn’t do anything to prevent the exposure of the iframe in the parent doc

However is the iframe in the parent doc could be consistently set to be hidden / taken out of the tab order, then that could prevent the nested iframe content from being accessible

I fail to understand why there should be any distinction whether aria-hidden is set to the html/body elements within an iframe or not, since it’d be unnecessary if the iframe in the parent doc was properly hidden, and if the iframe was not properly hidden, then respecting the aria-hidden attribute in that context would result in the problem we are trying to solve with this change

spectranaut · 2024-05-02T20:53:31Z

Adding agenda to "get consensus" re: Aaron's concerns so we can move this one forward!

spectranaut · 2024-05-09T18:17:21Z

discussed in https://www.w3.org/2024/05/09-aria-minutes.html#t10

Decision to move forward

aleventhal · 2024-05-10T14:19:36Z

Ok, let's go with disallowing aria-hidden on <body> and any document element <html>, <svg>.

index.html

aleventhal

Excellent. I can't find anything that would be confusing, vague or isn't a clear improvement.

companion PR to #1880

aleventhal · 2024-07-09T20:42:26Z

In terms of "waiting for implementations". Chrome has implemented this.

pkra · 2024-07-10T08:20:29Z

@scottaohara the WebKit issue also seems to have been resolved, so this might be ready to merge.

scottaohara · 2024-07-11T16:24:56Z

related HTML AAM PR has been merged.

scottaohara · 2024-12-09T20:01:38Z

@jnurthen @spectranaut i think this has been ready to merge for awhile? at least chromium/webkit have implemented per comments here

SHA: 951479e Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

prevent use of aria-hidden=true on document root elements

2c13489

closes #1254 @cookiecrook I took a first stab at drafting up the author and UA must nots. Please revise however you see fit.

cookiecrook reviewed Mar 3, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

index.html Outdated Show resolved Hide resolved

jnurthen requested review from jcsteh, ariellalgilmore and aleventhal March 9, 2023 18:47

jcsteh reviewed Mar 10, 2023

View reviewed changes

scottaohara and others added 2 commits March 24, 2023 13:52

Update index.html

16bb9e7

Co-authored-by: James Craig <[email protected]>

Update index.html

d138d8e

Co-authored-by: James Craig <[email protected]>

Merge branch 'main' into aria-hidden-issue-1254

00cf9f5

scottaohara commented Apr 12, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

8601da8

scottaohara commented Apr 12, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

001cf7b

cookiecrook approved these changes Apr 18, 2023

View reviewed changes

pkra added this to the ARIA 1.3 milestone Jun 28, 2023

scottaohara commented Nov 7, 2023

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

45112d1

jnurthen added Agenda and removed Agenda labels Nov 7, 2023

aleventhal approved these changes Nov 7, 2023

View reviewed changes

scottaohara added a commit to w3c/html-aam that referenced this pull request Nov 15, 2023

UA ignore aria-hidden on root elements

f6d3882

companion PR to w3c/aria#1880

scottaohara mentioned this pull request Nov 15, 2023

UA ignore aria-hidden on root elements w3c/html-aam#516

Closed

scottaohara mentioned this pull request Feb 16, 2024

ARIA in HTML update for body element validator/validator#1559

Open

spectranaut added the waiting for implementations Cannot be merged until there are two browser impls or one impl + impl commit label Feb 22, 2024

JonWBedard mentioned this pull request Apr 15, 2024

AX: aria-hidden=true should be ignored on the body and html elements WebKit/WebKit#27294

Closed

aleventhal approved these changes Apr 25, 2024

View reviewed changes

cookiecrook reviewed Apr 25, 2024

View reviewed changes

aleventhal reviewed Apr 26, 2024

View reviewed changes

aleventhal self-requested a review April 26, 2024 14:32

spectranaut added the Agenda label May 2, 2024

Merge branch 'main' into aria-hidden-issue-1254

7557d8f

scottaohara commented May 10, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

deb12c2

scottaohara commented May 10, 2024

View reviewed changes

index.html Outdated Show resolved Hide resolved

Update index.html

f15f533

aleventhal approved these changes May 17, 2024

View reviewed changes

jcsteh approved these changes May 20, 2024

View reviewed changes

scottaohara mentioned this pull request May 20, 2024

Rethink how "hidden" is aria-hidden content? #1951

Open

jnurthen removed the Agenda label May 21, 2024

pkra pushed a commit that referenced this pull request May 23, 2024

UA ignore aria-hidden on root elements

7c2b21f

companion PR to #1880

pkra added the spec:aria label Jun 14, 2024

jnurthen merged commit 951479e into main Dec 11, 2024
7 checks passed

jnurthen removed the waiting for implementations Cannot be merged until there are two browser impls or one impl + impl commit label Dec 11, 2024

github-actions bot added a commit that referenced this pull request Dec 11, 2024

prevent use of aria-hidden=true on document root elements (#1880)

0a7bc50

SHA: 951479e Reason: push, by jnurthen Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prevent use of aria-hidden=true on document root elements #1880

prevent use of aria-hidden=true on document root elements #1880

scottaohara commented Mar 3, 2023 •

edited by pr-preview bot

Loading

cookiecrook left a comment

jcsteh left a comment

scottaohara commented Mar 24, 2023

aleventhal left a comment

cookiecrook left a comment •

edited

Loading

aleventhal commented Apr 26, 2024

aleventhal left a comment

cookiecrook commented Apr 26, 2024

aleventhal commented Apr 26, 2024

scottaohara commented Apr 27, 2024

spectranaut commented May 2, 2024

spectranaut commented May 9, 2024

aleventhal commented May 10, 2024 •

edited

Loading

aleventhal left a comment

aleventhal commented Jul 9, 2024

pkra commented Jul 10, 2024

scottaohara commented Jul 11, 2024

scottaohara commented Dec 9, 2024

prevent use of aria-hidden=true on document root elements #1880

prevent use of aria-hidden=true on document root elements #1880

Conversation

scottaohara commented Mar 3, 2023 • edited by pr-preview bot Loading

Implementation tracking

cookiecrook left a comment

Choose a reason for hiding this comment

jcsteh left a comment

Choose a reason for hiding this comment

scottaohara commented Mar 24, 2023

aleventhal left a comment

Choose a reason for hiding this comment

cookiecrook left a comment • edited Loading

Choose a reason for hiding this comment

aleventhal commented Apr 26, 2024

aleventhal left a comment

Choose a reason for hiding this comment

cookiecrook commented Apr 26, 2024

aleventhal commented Apr 26, 2024

scottaohara commented Apr 27, 2024

spectranaut commented May 2, 2024

spectranaut commented May 9, 2024

aleventhal commented May 10, 2024 • edited Loading

aleventhal left a comment

Choose a reason for hiding this comment

aleventhal commented Jul 9, 2024

pkra commented Jul 10, 2024

scottaohara commented Jul 11, 2024

scottaohara commented Dec 9, 2024

scottaohara commented Mar 3, 2023 •

edited by pr-preview bot

Loading

cookiecrook left a comment •

edited

Loading

aleventhal commented May 10, 2024 •

edited

Loading