-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make aria-relevant and ariaRelevant reflect #2326
Make aria-relevant and ariaRelevant reflect #2326
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for raising this, @sideshowbarker! In addition to the WPT test confirming reflection, I am indeed seeing ariaRelevant in the accessibility WebIDL definition files for the 3 major browsers: @cookiecrook had raised a newer related issue describing the general challenges with reflecting this attribute which was why it was removed: #1267. I'll assign this one to myself to discuss at a future ARIA WG meeting. |
Discussed today's aria working group meeting during triage: https://www.w3.org/2024/09/05-aria-minutes#t02 |
Yes, since this reflects the current reality, let's approve it.... In the meeting this morning I suggested, "revisit after the ongoing IDL discussions resolve," (so @spectranaut added the Do Not Merge label) but since all 3 engines are already shipping it, this is okay to merge as-is, IMO. |
I think the table in Section 10.2 ARIA Attribute Correspondence also needs updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sideshowbarker -- thanks for this, can you update the table here too: https://w3c.github.io/aria/#accessibilityroleandproperties-correspondence
Yep, will do tomorrow or later this week. (I’m in the midst of finishing up implementation of accessible-name computation in Ladybird. But I expect to get the last patch/PR for that pushed for review today.) |
33712f9
to
5b9e38d
Compare
Now updated. Sorry for having taken so ridiculously long to get around to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! :)
@rahim can we get one more +1 on this, then we will land? |
I think you meant @rahimabdi 😄 |
SHA: 19a6325 Reason: push, by spectranaut Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 19a6325 Reason: push, by AlwayzN4ever011 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The
ariaRelevant
IDL attribute seems to have been intentionally commented out from theARIAMixin
interface in 646f093 — without any explanation that I could find, including not in the related issue at #1058.But since at https://w3c.github.io/aria/#idl-reflection-attribute-values the spec says:
…and since there’s a test case included in http://wpt.live/html/dom/aria-attribute-reflection.html, and WebKit, Gecko, and Blink all pass that test — then it seems
ariaRelevant
needs to be included inARIAMixin
in the spec.Preview | Diff