Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defined boolean attribute type #521

Merged
merged 2 commits into from
Nov 24, 2024
Merged

defined boolean attribute type #521

merged 2 commits into from
Nov 24, 2024

Conversation

davidcarlisle
Copy link
Collaborator

Add a boolean attrbute type (refencing the existing definition in MathML-Core), replace all "true" | "false" by a reference to boolean.

This addresses a main case highlighted by #178

@NSoiffer
Copy link
Contributor

Nothing wrong with this as a start, but don't most of the attribute values need to be ASCII case insensitive? Or do you think only those that use boolean values?

@NSoiffer NSoiffer merged commit b8e40c8 into main Nov 24, 2024
1 of 3 checks passed
@davidcarlisle
Copy link
Collaborator Author

@NSoiffer I think values that are case insensitive in mathml-core need to be case insensitive in full, so that anything valid in core is valid in full (and that's already what the schema implemented even though the spec wording did not). Making other things case insensitive is possibly the right thing to do but less important I think. Certainly in an xml world there is less pressure to be case insensitive, eg xml schema for xhtml and svg are typically case sensitive, it is the versions embedded in html where this is most natural.

But I was not suggesting that we don't change the others, just doing a simple but important case as low hanging fruit, that could easily be done and reviewed on a wet afternoon.

@NSoiffer
Copy link
Contributor

Yes, very sensible. I'll open an issue on whether we should make all the fixed value ones (such as "left"/"center"/"right") be case sensitive or not. If we decide not to, then there's nothing to do.

github-actions bot added a commit that referenced this pull request Nov 25, 2024
SHA: b8e40c8
Reason: push, by NSoiffer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants