Use certificate serial number in Subject Name #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backkem
changed the title
anssiko
approved these changes
May 16, 2024
|
@mfoltzgoogle PTAL? |
This resolves the circular dependency in agent certificate fingerprint. Resolves w3c#276
markafoltz
reviewed
May 31, 2024
|
TODO:
|
|
I updated the PR based on our discussion from TPAC with a slight adjustment. I retained the counter in the agent serial number to make it easier to implement certificate rotation in the future (it won't require the agent to generate a new UUID). PTAL @backkem |
|
Looks good to me. It addresses both the circularity and SNI issue. (I can't add a review, maybe because I opened the PR.) Thanks for picking this up Mark. Sorry I didn't find the time yet. |
|
Thanks. I am going to revert the SVG changes and submit them separately, as the SVG needs to be updated to reflect the updated PR. |
github-actions bot
added a commit
that referenced
this pull request
Oct 8, 2024
SHA: e3eace3 Reason: push, by markafoltz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 8, 2024
SHA: e3eace3 Reason: push, by markafoltz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 8, 2024
SHA: e3eace3 Reason: push, by markafoltz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the circular dependency in agent certificate fingerprint.
Resolves #276
Preview | Diff