Treat a null elementNs in getPropertyType/geAtributeType as the HTML … #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namespace This is the behavior that Chromium and WebKit currently implement, see https://phabricator.services.mozilla.com/D226547 Currently, it seems that the "interface for localName and elementNs" would fallback to `Element`, similarly to what happens with `document.createElementNS(null, "div")` for example. Note that a null attrNs is already handled by the spec. See also w3c#553 for details.
|
cc @lukewarlow @koto |
koto
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…namespace
This is the behavior that Chromium and WebKit currently implement, see https://phabricator.services.mozilla.com/D226547
Currently, it seems that the "interface for localName and elementNs" would fallback to
Element, similarly to what happens withdocument.createElementNS(null, "div")for example.Note that a null attrNs is already handled by the spec.
See also #553 for details.
Preview | Diff