Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec-prod] Dereference secret name in step #196

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Apr 27, 2021

The secrets context is not available at the matrix level. See discussion in:
w3c/spec-prod#55 (comment)

Workaround is to list the secret name at that level and to dereference it in the actual step.

tidoust added 2 commits April 27, 2021 14:44
The `secrets` context is not available at the `matrix` level. See discussion in:
w3c/spec-prod#55 (comment)

Workaround is to list the secret name at that level and to dereference it in the
actual step.
The spec-prod action fails to detect that the specs are Bikeshed documents
(likely because filenames don't end with `.bs`).
@tidoust
Copy link
Member Author

tidoust commented Apr 27, 2021

@chcunningham This should fix the job. I note that the use of a matrix in the YML file effectively means that the multiple instances of the job (one for each entry in the matrix) run each time. Hence the "3 successful checks" here.

@tidoust tidoust requested a review from chcunningham April 27, 2021 12:52
Copy link
Collaborator

@chcunningham chcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the quick fix!

@chcunningham chcunningham merged commit 52a98a3 into main Apr 27, 2021
github-actions bot added a commit that referenced this pull request Apr 27, 2021
SHA: 52a98a3
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2021
SHA: 52a98a3
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 27, 2021
SHA: 52a98a3
Reason: push, by @chcunningham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tidoust
Copy link
Member Author

tidoust commented Apr 27, 2021

Success... almost ;)

Publication to gh-branch succeeded for the 3 documents. Publication of WebCodecs to /TR succeeded as well although job still reported a failure for some reason. Publication of the registry and AVC documents to /TR failed due to a shortname mismatch. I'll look into it.

@chcunningham
Copy link
Collaborator

Thanks!

@chcunningham chcunningham deleted the fix-spec-prod branch June 2, 2021 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants