Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browsingContext.navigationCommitted event and wait for it when no wait condition is provided #855

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Add browsingContext.navigationCommitted event and wait for it when no wait condition is provided #855

merged 4 commits into from
Jan 31, 2025

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jan 13, 2025 •
edited by pr-preview bot
Loading

Closes #788
HTML spec: whatwg/html#10910

Preview | Diff

@OrKoN OrKoN force-pushed the orkon/navigation-committed branch from 1573c2f to 31fd732 Compare January 13, 2025 13:07
@OrKoN OrKoN requested a review from sadym-chromium January 13, 2025 13:07
@OrKoN OrKoN mentioned this pull request Jan 13, 2025
Merged
6 tasks
@OrKoN OrKoN changed the title Handle navigation committed event Specify navigation committed event Jan 13, 2025
sadym-chromium
sadym-chromium reviewed Jan 14, 2025
View reviewed changes
index.bs Outdated Show resolved Hide resolved
OrKoN
OrKoN commented Jan 14, 2025
View reviewed changes
index.bs Outdated Show resolved Hide resolved
whimboo
whimboo reviewed Jan 14, 2025
View reviewed changes
index.bs Outdated Show resolved Hide resolved
whimboo
whimboo reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do with the browsingContext.navigationAborted event? Should we deprecate it? See #788 (comment)

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 15, 2025

What should we do with the browsingContext.navigationAborted event? Should we deprecate it? See #788 (comment)

what is the specific reason for deprecating navigationAborted? I think we can discuss it separately.

@OrKoN OrKoN mentioned this pull request Jan 15, 2025
Open
3 tasks
@OrKoN @whimboo
Update index.bs
f43d101 
Co-authored-by: Henrik Skupin <[email protected]>
@OrKoN OrKoN requested a review from jgraham January 15, 2025 08:08
@whimboo
Copy link
Contributor

whimboo commented Jan 15, 2025

What should we do with the browsingContext.navigationAborted event? Should we deprecate it? See #788 (comment)

what is the specific reason for deprecating navigationAborted? I think we can discuss it separately.

See the details in the referenced comment. That's all what I got. Happy to move it to a follow-up.

@OrKoN OrKoN changed the title Specify navigation committed event Add browsingContext.navigationCommitted event and wait for it when no wait condition is provided Jan 15, 2025
jgraham
jgraham approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API change seem good. It would be nice to make sure we have clarity at least amongst the WebDriver folks on the HTML side of the change before landing this.

whimboo
whimboo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

sadym-chromium
sadym-chromium reviewed Jan 29, 2025
View reviewed changes
index.bs

1. If |command parameters| [=map/contains=] <code>wait</code>
and |command parameters|[<code>wait</code>] is not "<code>none</code>",
set |wait condition| to |command parameters|[<code>wait</code>].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set |wait condition| to |command parameters|[<code>wait</code>].
set |wait condition| to |command parameters|[<code>wait</code>].
Note: "<code>none</code>" condition is a synonym for "<code>committed</code>".

domenic pushed a commit to whatwg/html that referenced this pull request Jan 31, 2025
@OrKoN
Notify WebDriver BiDi about "committed" navigations
5c7947f 
This notifies automation sessions when a navigation results in a new document being loaded.  See w3c/webdriver-bidi#788 and w3c/webdriver-bidi#855.
@whimboo
Copy link
Contributor

whimboo commented Jan 31, 2025

@OrKoN the HTML spec PR got merged. I assume this one is ready as well?

@OrKoN OrKoN merged commit 0713f9c into main Jan 31, 2025
5 checks passed
@OrKoN OrKoN deleted the orkon/navigation-committed branch January 31, 2025 11:31
@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 31, 2025

Implementation tracking on our side GoogleChromeLabs/chromium-bidi#2982

@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 31, 2025

If someone plans to look into WPT before we get to it during the implementation, please post on the issue.

github-actions bot added a commit that referenced this pull request Jan 31, 2025
@OrKoN @github-actions
Add browsingContext.navigationCommitted event and wait for it when no…
275d1da 
… wait condition is provided (#855)

SHA: 0713f9c
Reason: push, by OrKoN

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@whimboo
Copy link
Contributor

whimboo commented Jan 31, 2025

Tests landed via web-platform-tests/wpt#50413.

@sadym-chromium are those complete? (I didn't check them yet). Thanks!

@sadym-chromium
Copy link
Contributor

Tests landed via web-platform-tests/wpt#50413.

@sadym-chromium are those complete? (I didn't check them yet). Thanks!

After the PR web-platform-tests/wpt#50419 is merged, I believe the tests are complete. But of course they can be extended with more exotic cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadym-chromium sadym-chromium sadym-chromium approved these changes

@jgraham jgraham jgraham approved these changes

@whimboo whimboo whimboo approved these changes

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for a navigationCommitted event to inform immediately about the navigation status
4 participants
@OrKoN @whimboo @sadym-chromium @jgraham