Create SpellRouter_Milestone_M1.md #1081

dudo50 · 2023-12-15T22:05:40Z

Milestone Delivery Checklist

The milestone-delivery-template.md has been copied and updated.
This pull request is being made by the same account as the accepted application.
I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2057

dudo50 · 2023-12-15T22:09:07Z

We have noticed, that there has been another change to payments. And BTC is no longer available and our grant was accepted with BTC as a payment option. Please let us know if this needs changing so we can open PR in the grants repository to fix this. We want to switch to FIAT instead then (Please let us know what is needed also for this switch). We have for now not yet submitted an invoice due to this.

With kind regards,
Team ParaSpell

niklabh · 2023-12-16T13:18:36Z

Hey team, i am getting error when running playground:

± |main U:2 ?:3 ✗| → yarn dev

  VITE v5.0.7  ready in 205 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "getAllTradingPairs"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:9:
      13 │ import { getAllTradingPairs, findBestTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools,...
         ╵          ~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "findBestTradeRecursively"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:29:
      13 │ import { getAllTradingPairs, findBestTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools,...
         ╵                              ~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "StandardLiquidityPool"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:55:
      13 │ import { getAllTradingPairs, findBestTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools,...
         ╵                                                        ~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "StableLiquidityPool"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:78:
      13 │ import { getAllTradingPairs, findBestTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools,...
         ╵                                                                               ~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "PoolType"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:99:
      13 │ ...etAllTradingPairs, findBestTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStab...
         ╵                                                                                             ~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "encodeSwapParamsForStandardPoolsOnly"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:109:
      13 │ ...estTradeRecursively, StandardLiquidityPool, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isSt...
         ╵                                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "encodeSwapParamsForStandardAndStablePools"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:147:
      13 │ ...ol, StableLiquidityPool, PoolType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isStableMetaPool, isStandardPool, StableLiqu...
         ╵                                                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "isStableMultiPathElement"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:190:
      13 │ ...lType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isStableMetaPool, isStandardPool, StableLiquidityMetaPool, } from "./amm/";
         ╵                                                                                            ~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "isStableMetaPool"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:216:
      13 │ ...lType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isStableMetaPool, isStandardPool, StableLiquidityMetaPool, } from "./amm/";
         ╵                                                                                                                      ~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "isStandardPool"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:234:
      13 │ ...lType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isStableMetaPool, isStandardPool, StableLiquidityMetaPool, } from "./amm/";
         ╵                                                                                                                                        ~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js" for import "StableLiquidityMetaPool"

    node_modules/@interlay/interbtc-api/build/esm/src/parachain/amm.js:13:250:
      13 │ ...lType, encodeSwapParamsForStandardPoolsOnly, encodeSwapParamsForStandardAndStablePools, isStableMultiPathElement, isStableMetaPool, isStandardPool, StableLiquidityMetaPool, } from "./amm/";
         ╵                                                                                                                                                        ~~~~~~~~~~~~~~~~~~~~~~~

niklabh · 2023-12-16T13:19:09Z

Seems like interlay APIs has changed.

dudo50 · 2023-12-16T13:31:10Z

Thanks @niklabh for letting us know, I have tried to replicate your error but I am unable. Could you please provide us with your system specs, operating system you are running, nodejs and yarn versions? Also git log would help us! Thanks!

With kind regards,
Team ParaSpell

niklabh · 2023-12-16T13:35:56Z

Thanks @niklabh for letting us know, I have tried to replicate your error but I am unable. Could you please provide us with your system specs, operating system you are running, nodejs and yarn versions? Also git log would help us! Thanks!

With kind regards, Team ParaSpell

Here are the versions:

 2023-12-16 19:05:12 ⌚  nikhil-Blade-14-RZ09-0370 in ~/w3f/xcm-router
± |main U:2 ?:3 ✗| → uname -a
Linux nikhil-Blade-14-RZ09-0370 5.15.0-48-generic #54~20.04.1-Ubuntu SMP Thu Sep 1 16:17:26 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

 2023-12-16 19:05:16 ⌚  nikhil-Blade-14-RZ09-0370 in ~/w3f/xcm-router
± |main U:2 ?:3 ✗| → yarn -v
3.5.0

 2023-12-16 19:05:20 ⌚  nikhil-Blade-14-RZ09-0370 in ~/w3f/xcm-router
± |main U:2 ?:3 ✗| → node -v
v21.4.0

niklabh · 2023-12-16T13:36:27Z

Thanks @niklabh for letting us know, I have tried to replicate your error but I am unable. Could you please provide us with your system specs, operating system you are running, nodejs and yarn versions? Also git log would help us! Thanks!
With kind regards, Team ParaSpell

Here are the versions:

2023-12-16 19:05:12 ⌚ nikhil-Blade-14-RZ09-0370 in /w3f/xcm-router
± |main U:2 ?:3 ✗| → uname -a
Linux nikhil-Blade-14-RZ09-0370 5.15.0-48-generic #5420.04.1-Ubuntu SMP Thu Sep 1 16:17:26 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

2023-12-16 19:05:16 ⌚ nikhil-Blade-14-RZ09-0370 in ~/w3f/xcm-router
± |main U:2 ?:3 ✗| → yarn -v
3.5.0

2023-12-16 19:05:20 ⌚ nikhil-Blade-14-RZ09-0370 in ~/w3f/xcm-router
± |main U:2 ?:3 ✗| → node -v
v21.4.0

± |main U:2 ?:3 ✗| → git log
commit 613af67601ecbc7f4dd3b6b47a0427ede028bf9c (HEAD -> main, origin/main, origin/HEAD)
Author: Rikkard29 [email protected]
Date: Fri Dec 15 23:08:06 2023 +0100

Use published package instead of local 📦

commit 9e6f87e66b3857ea75dc73a4c81301354a3517cf (tag: v0.0.1)
Author: Rikkard29 [email protected]
Date: Fri Dec 15 23:02:06 2023 +0100

chore(release): 0.0.1

niklabh · 2023-12-16T13:38:22Z

Hey team, thanks for the high quality delivery of the milestone 1. I have added an external evaluation. #1082. Other than playground other features are working fine.

dudo50 · 2023-12-16T13:40:42Z

@niklabh , thanks for providing details, we will go ahead and try to resolve this issue today. We will ping you once we have found the problem. Also thanks for the positive comment regarding delivery!

With kind regards,
Team ParaSpell

dudo50 · 2023-12-16T13:51:44Z

@niklabh one more thing, could you also provide the output of yarn install (When you delete node modules)? It should print that patches were applied (as we have 2 patches, 1 for interlay SDK and 1 for hydradx SDK). The only diff we can see right now between our systems is different yarn versions. We use v1.22, and yours is v3.5.0 (We have to use older v1 because one DEX SDK only supports v1 namely Mangata SDK).

Should print the following lines:

With kind regards,
Team ParaSpell

dudo50 · 2023-12-16T14:09:50Z

@niklabh, I have tried with your 3.5.0 version of yarn and I was able to replicate your problem. Could you please manually switch to yarn 1.22.1? We will open an issue in MangataSDK repository for them to patch their work (They are also the reason why pnpm is not working). For now, we have to work with what we have.

This command should help you:

cd playground
yarn set version 1.22.1

It sets the yarn version locally (in that folder) to 1.22.1
Playground should work then just fine.

With kind regards,
Team ParaSpell

niklabh · 2023-12-16T16:42:02Z

Thanks, This worked.

niklabh · 2023-12-16T16:48:41Z

Updated the evaluation to accepted: #1081

dudo50 · 2023-12-16T17:08:34Z

Thanks @niklabh for thorough evaluation. We have enjoyed this process and experience with you.

With kind regards,
Team ParaSpell

semuelle · 2023-12-21T16:20:06Z

Hey @dudo50. I just confirmed @niklabh's evaluation and your milestone is hereby accepted. Congratulations. As usual, good work!

github-actions · 2023-12-21T16:20:47Z

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

github-actions · 2023-12-21T16:20:47Z

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

dudo50 · 2023-12-21T17:06:13Z

@semuelle, thanks for your kind words!

One more question for you before we fill invoice:
Please refer to our first comment:
#1081 (comment)

semuelle · 2023-12-22T12:05:47Z

Please let us know if this needs changing so we can open PR in the grants repository to fix this.

Hey @dudo50. Existing grant agreements don't have to be changed. If you do want to change the payment details, please do so as per the new guidelines. Fiat would be fine, of course.

dudo50 · 2023-12-22T14:01:25Z

Thanks @semuelle ,
We have requested change via the following PR: w3f/Grants-Program#2163
We will also submit an updated invoice within an hour from this comment.

dudo50 · 2023-12-22T14:24:02Z

@semuelle ,
An invoice with updated payment details (FIAT) was just submitted.

With kind regards,
Team ParaSpell

Create SpellRouter_Milestone_M1.md

4e3212b

niklabh mentioned this pull request Dec 16, 2023

Added external evaluation for SpellRouter Milestone 1 #1082

Merged

semuelle merged commit 0418712 into w3f:master Dec 21, 2023
6 checks passed

dudo50 mentioned this pull request Dec 21, 2023

Create SpellRouter_Milestone_M2.md #1087

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create SpellRouter_Milestone_M1.md #1081

Create SpellRouter_Milestone_M1.md #1081

dudo50 commented Dec 15, 2023

dudo50 commented Dec 15, 2023 •

edited

Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023 •

edited

Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023

semuelle commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

dudo50 commented Dec 21, 2023

semuelle commented Dec 22, 2023

dudo50 commented Dec 22, 2023

dudo50 commented Dec 22, 2023

Create SpellRouter_Milestone_M1.md #1081

Create SpellRouter_Milestone_M1.md #1081

Conversation

dudo50 commented Dec 15, 2023

Milestone Delivery Checklist

dudo50 commented Dec 15, 2023 • edited Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023 • edited Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023 • edited Loading

dudo50 commented Dec 16, 2023 • edited Loading

dudo50 commented Dec 16, 2023 • edited Loading

niklabh commented Dec 16, 2023

niklabh commented Dec 16, 2023

dudo50 commented Dec 16, 2023

semuelle commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

dudo50 commented Dec 21, 2023

semuelle commented Dec 22, 2023

dudo50 commented Dec 22, 2023

dudo50 commented Dec 22, 2023

dudo50 commented Dec 15, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading

dudo50 commented Dec 16, 2023 •

edited

Loading