Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 650 authority discovery #669

Merged
merged 15 commits into from
Aug 14, 2023
Merged

Conversation

heversonbr
Copy link
Contributor

This adds the sub-section "Discovering authorities" to the Network Section of the Spec.
It describes the authority discovery mechanism and its interactions with Polkadot nodes and with the DHT layer.

Copy link
Collaborator

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
docs/chap-networking.md Outdated Show resolved Hide resolved
@heversonbr heversonbr requested a review from Noc2 July 25, 2023 14:06
@heversonbr heversonbr self-assigned this Aug 7, 2023
Copy link
Contributor

@bhargavbh bhargavbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

small spelling fixes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small spelling fixes

@tomaka
Copy link
Collaborator

tomaka commented Aug 9, 2023

I know I'm being a pain, but ideally a PR that describes authority discovery shouldn't at the same time make small unrelated changes to half of the networking chapter.
Pull requests are free, there's no need to merge multiple unrelated changes into one PR.

Merge latest version of main into local issue-650-authority-discovery
@heversonbr heversonbr merged commit 70931c9 into main Aug 14, 2023
3 checks passed
@heversonbr heversonbr deleted the issue-650-authority-discovery branch August 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants