Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg Async Backing #5176

Merged
merged 71 commits into from
Oct 5, 2023
Merged

Reorg Async Backing #5176

merged 71 commits into from
Oct 5, 2023

Conversation

filippoweb3
Copy link
Contributor

  • reorg content
  • figure addition

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Sep 11, 2023
@filippoweb3
Copy link
Contributor Author

filippoweb3 commented Sep 11, 2023

@BradleyOlson64 @CrackTheCode016 I reorganized the text after reading the academy docs. Can you please check if everything makes sense? I think it would be beneficial to add some figures that explain how asynch baking can be configured in case of high demand and low demand. As far as I understand, the length of the included segments plays an important role.

Copy link
Contributor

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a preliminary review, thank you for rearranging the content. I have a lot of notes on prospective parachains, and I think that will give the detail we need to fully drive the point home.

For those who aren't aware, @filippoweb3 and I wanted to also eventually answer the question:

  • With less time needed for backing, how can more blockspace be utilized in less time?

I think it is partially answered here already, but thought I'd mention :)

docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/assets/sync-backing-nofill.png Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
docs/learn/learn-async-backing.md Outdated Show resolved Hide resolved
@shawntabrizi
Copy link
Contributor

shawntabrizi commented Oct 3, 2023

@Sophia-Gold had a nice picture which concisely shows async backing and the performance increase from it:

https://youtu.be/7AWRCt_SLJc?si=N66meIh0hnh6YgRz&t=503

image

I think this image needs to be every article which talks about async backing.

EDIT: I see you have an image like this, but it is certainly not as clear as this one. The colors, fonts, sizing, everything just makes it harder to see simple details.

@filippoweb3
Copy link
Contributor Author

Thanks for the feedback @shawntabrizi, I implemented it. I will wait for final approval by @Sophia-Gold and @BradleyOlson64 so that I can finally merge this beast!

@DrW3RK DrW3RK removed the A0 - Do Not Merge Pull request should not yet be merged. label Oct 5, 2023
@DrW3RK DrW3RK merged commit dbe2d6f into master Oct 5, 2023
3 checks passed
@DrW3RK DrW3RK deleted the reorg-async-backing branch October 5, 2023 13:28
@filippoweb3 filippoweb3 removed the request for review from Sophia-Gold October 6, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Please Review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants