Add missing .specific

wagtail · Jan 10, 2020 · b65db54 · b65db54
1 parent 45f9c0f
commit b65db54
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/wagtail_localize/translation/models.py b/wagtail_localize/translation/models.py
@@ -102,15 +102,15 @@ class TranslatableRevision(models.Model):
 
     @classmethod
     def get_or_create_from_page_revision(cls, page_revision):
-        object, created = TranslatableObject.objects.get_or_create_from_instance(
-            page_revision.page
-        )
+        page = page_revision.page.specific
+
+        object, created = TranslatableObject.objects.get_or_create_from_instance(page)
 
         return TranslatableRevision.objects.get_or_create(
             object=object,
             page_revision=page_revision,
             defaults={
-                "locale_id": page_revision.page.locale_id,
+                "locale_id": page.locale_id,
                 "content_json": page_revision.content_json,
                 "created_at": page_revision.created_at,
             },

diff --git a/wagtail_localize/translation/tests/test_translatablerevision.py b/wagtail_localize/translation/tests/test_translatablerevision.py
@@ -60,6 +60,10 @@ def test_create(self):
         TranslatableRevision.objects.all().delete()
 
         page_revision = self.page.get_latest_revision()
+
+        # Refetch the page revision so that it has the generic Page object associated
+        page_revision.refresh_from_db()
+
         revision, created = TranslatableRevision.get_or_create_from_page_revision(
             page_revision
         )