Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC-10: Set Up RuboCop #2

Merged
merged 7 commits into from
Jan 14, 2025
Merged

PC-10: Set Up RuboCop #2

merged 7 commits into from
Jan 14, 2025

Conversation

vb-cmd
Copy link
Collaborator

@vb-cmd vb-cmd commented Jan 14, 2025 •
edited
Loading

PC-10 Powered by Pull Request Badge

Description

  • Added platform to Gemfile.lock
  • Added public/assets folder to .gitignore
  • Added rubocop-rails gem to the project
  • Added some rules

rogergraves
rogergraves reviewed Jan 14, 2025
View reviewed changes
Gemfile Show resolved Hide resolved
@rogergraves rogergraves added review needed Code reviews needed by the minimum number of developers required safe to merge w/o testing Manual QA testing is not required on this branch labels Jan 14, 2025
Maryna-Harasko
Maryna-Harasko reviewed Jan 14, 2025
View reviewed changes
.rubocop.yml Outdated Show resolved Hide resolved
@Maryna-Harasko Maryna-Harasko self-requested a review January 14, 2025 11:59
@Maryna-Harasko Maryna-Harasko added review done Code reviews are completed by the minimum number of developers required and removed review needed Code reviews needed by the minimum number of developers required labels Jan 14, 2025
@Maryna-Harasko Maryna-Harasko merged commit ad83c71 into master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogergraves rogergraves rogergraves approved these changes

@Maryna-Harasko Maryna-Harasko Maryna-Harasko approved these changes

Assignees

@AndrewRiabets AndrewRiabets

@vb-cmd vb-cmd

Labels
review done Code reviews are completed by the minimum number of developers required safe to merge w/o testing Manual QA testing is not required on this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vb-cmd @rogergraves @Maryna-Harasko @AndrewRiabets