Make web_pipe compatible with dry-auto_inject #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove the built-in resolution of plugs from a container and instead
rely on the common mechanism provided by dry-auto_inject.
As we're already allowing the injection of plugs and middlewares through
keyword arguents given on `#initialize`, web_pipe remains compatible
with the keyword arguments strategy of dry-auto_inject. We make sure
that the order of inclusion of either web_pipe or dry-auto_inject is
irrelevant for a correct behavior via dispatching any extra keyword
arguments to `super`.
```ruby
WebPipe.load_extensions(:params)
class CreateUserApp
include WebPipe
include Deps[:create_user]
plug :html, WebPipe::Plugs::ContentType.('text/html')
plug :create
private
def create(conn)
create_user.(conn.params)
end
end
```
waiting-for-dev
force-pushed
the
waiting-for-dev/dry_auto_inject
branch
from
79f6c53 to
6a69fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the built-in resolution of plugs from a container and instead rely on the common mechanism provided by dry-auto_inject.
As we're already allowing the injection of plugs and middlewares through keyword arguents given on
#initialize, web_pipe remains compatible with the keyword arguments strategy of dry-auto_inject. We make sure that the order of inclusion of either web_pipe or dry-auto_inject is irrelevant for a correct behavior via dispatching any extra keyword arguments tosuper.