Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: request permissions for custom hosts (resolve #209) #221

Closed
wants to merge 1 commit into from

Conversation

muety
Copy link

@muety muety commented Jul 8, 2023

Resolve #209

@gandarez
Copy link
Member

gandarez commented Jul 9, 2023

@jvelezpo would you like to review it?

@jvelezpo
Copy link
Contributor

There is an issue running on FF

Uncaught (in promise) Error: Type error for parameter permissions (Error processing permissions.0: Value "https://wakapi.dev/*" must either: must either [be one of ["idle"], be one of ["menus.overrideContext"], be one of ["search"], be one of ["activeTab"], be one of ["cookies"], be one of ["scripting"], or be one of ["webRequest", "webRequestBlocking", "webRequestFilterResponse", "webRequestFilterResponse.serviceWorkerScript"]], be one of ["clipboardRead", "clipboardWrite", "geolocation", "notifications"], be one of ["bookmarks"], be one of ["browsingData"], be one of ["devtools"], be one of ["history"], be one of ["find"], be one of ["pkcs11"], be one of ["sessions"], be one of ["topSites"], be one of ["browserSettings"], be one of ["management"], be one of ["tabs", "tabHide"], be one of ["privacy"], be one of ["proxy"], be one of ["webNavigation"], be one of ["declarativeNetRequestFeedback"], be one of ["downloads", "downloads.open"], or be one of ["nativeMessaging"]) for permissions.request.
    handleSubmit Options.tsx:131
    React 23
    <anonymous> options.tsx:10
    <anonymous> options.js:47972
    <anonymous> options.js:47974
[Options.tsx:131:43](webpack://chrome-wakatime/src/components/Options.tsx)
    handleSubmit Options.tsx:165
    React 19
    forEach self-hosted:4439
    React 4
    <anonymous> options.tsx:10
    <anonymous> options.js:47972
    <anonymous> options.js:47974

I will be helping getting this fixed

@muety
Copy link
Author

muety commented Jul 10, 2023

Didn't get that error 🤔 How could I reproduce it?

I'd appreciate some help! I'm not too experienced with web extensions.

Btw., for Wakapi you'll have to put https://wakapi.dev/api/compat/wakatime/v1.

@jvelezpo
Copy link
Contributor

#222 (comment)

@jvelezpo
Copy link
Contributor

Closing, merged this other PR instead
#222

@jvelezpo jvelezpo closed this Jul 14, 2023
@muety
Copy link
Author

muety commented Jul 14, 2023

Awesome, thanks! When will the next release be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to request permissions for custom hosts
3 participants