Merge pull request #1060 from wakatime/misc/bolt-db-close-test

Validate error when closing bolt db in tests
wakatime · Jul 10, 2024 · 8d8ecab · 8d8ecab
2 parents d1ec33f + d12c3c7
commit 8d8ecab
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 8 deletions.
diff --git a/cmd/heartbeat/heartbeat_test.go b/cmd/heartbeat/heartbeat_test.go
@@ -372,7 +372,10 @@ func TestSendHeartbeats_ExtraHeartbeats_Sanitize(t *testing.T) {
 	db, err := bolt.Open(offlineQueueFile.Name(), 0600, nil)
 	require.NoError(t, err)
 
-	defer db.Close()
+	defer func() {
+		err = db.Close()
+		require.NoError(t, err)
+	}()
 
 	tx, err := db.Begin(true)
 	require.NoError(t, err)

diff --git a/cmd/offlinecount/offlinecount_test.go b/cmd/offlinecount/offlinecount_test.go
@@ -27,7 +27,9 @@ func TestOfflineCount_Empty(t *testing.T) {
 	require.NoError(t, err)
 
 	insertHeartbeatRecords(t, db, "heartbeats", []heartbeatRecord{})
-	db.Close()
+
+	err = db.Close()
+	require.NoError(t, err)
 
 	v := viper.New()
 	v.Set("verbose", true)
@@ -89,7 +91,8 @@ func TestOfflineCount(t *testing.T) {
 		},
 	})
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	v := viper.New()
 	v.Set("offline-count", true)

diff --git a/cmd/offlineprint/offlineprint_test.go b/cmd/offlineprint/offlineprint_test.go
@@ -43,7 +43,8 @@ func TestPrintOfflineHeartbeats(t *testing.T) {
 		},
 	})
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	v := viper.New()
 	v.Set("print-offline-heartbeats", 10)

diff --git a/cmd/offlinesync/offlinesync_test.go b/cmd/offlinesync/offlinesync_test.go
@@ -93,7 +93,8 @@ func TestSyncOfflineActivity(t *testing.T) {
 		},
 	})
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	v := viper.New()
 	v.Set("api-url", testServerURL)
@@ -181,7 +182,8 @@ func TestSyncOfflineActivity_MultipleApiKey(t *testing.T) {
 		},
 	})
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	v := viper.New()
 	v.Set("api-url", testServerURL)

diff --git a/cmd/run_test.go b/cmd/run_test.go
@@ -675,7 +675,8 @@ func TestRunCmdWithOfflineSync(t *testing.T) {
 		},
 	})
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	// setup test server
 	testServerURL, router, tearDown := setupTestServer()
@@ -738,7 +739,8 @@ func TestRunCmdWithOfflineSync(t *testing.T) {
 	})
 	require.NoError(t, err)
 
-	db.Close()
+	err = db.Close()
+	require.NoError(t, err)
 
 	require.Len(t, stored, 0)