Read extra heartbeats once #1076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
force-pushed
the
bugfix/read-extra-hh-once
branch
from
32f996f
to
e4ad352
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #1076 +/- ##
===========================================
- Coverage 63.03% 63.01% -0.03%
===========================================
Files 383 383
Lines 16504 16511 +7
===========================================
+ Hits 10403 10404 +1
- Misses 5533 5537 +4
- Partials 568 570 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alanhamlett
reviewed
Jul 24, 2024
| @@ -750,29 +752,20 @@ func readAPIKeyFromCommand(cmdStr string) (string, error) { | |||
| return strings.TrimSpace(string(out)), nil | |||
| } | |||
|
|
|||
| var extraHeartbeatsCache *[]heartbeat.Heartbeat // nolint:gochecknoglobals | |||
There was a problem hiding this comment.
I still want to use a semaphore to be sure it never reads stdin twice. It can't hurt.
alanhamlett
reviewed
Jul 24, 2024
| if err = offlinecmd.SaveHeartbeats(v, nil, queueFilepath); err == nil { | ||
| // it prevents reading extra heartbeats again from stdin when we're rate limited. | ||
| // Otherwise, it would fail to read. | ||
| v.Set("extra-heartbeats", false) |
There was a problem hiding this comment.
I don't like this... it seems brittle.
auto-merge was automatically disabled
July 24, 2024 18:31
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents reading extra heartbeats more than once by setting
extra-heartbeatsflag to false when rate limited. It also includes an integration test to assert this behavior.