fix: logger issues after go-ethereum's migration to slog #8
+89
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
approved these changes
Jul 30, 2024
|
Noticed log output missing in tests, checking. |
vitvly
force-pushed
the
fix/go-ethereum-log-update
branch
from
07b6c9b
to
1425c5f
Compare
vitvly
force-pushed
the
fix/go-ethereum-log-update
branch
from
1425c5f
to
a02c0dc
Compare
|
@richard-ramos fixed log output issues. |
|
Converting to draft to wait until https://github.com/status-im/go-ethereum/tree/wip-rebase-2 is merged |
|
This PR #7 might also be closed once this one gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently used
go-ethereumversion (https://github.com/status-im/go-ethereum) is quite outdated. More recent upstream changes are available in https://github.com/status-im/go-ethereum/tree/wip-rebase-2 branch.This PR updates the dependency and fixes resulting logger-related issues.
More context here: status-im/status-go#5458