fix: use correct offset when converting commitment to bigint (#103)

waku-org · Mar 22, 2024 · 126bce3 · 126bce3
1 parent 3dc5908
commit 126bce3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/identity.ts b/src/identity.ts
@@ -14,7 +14,7 @@ export class IdentityCredential {
     const idNullifier = memKeys.subarray(32, 64);
     const idSecretHash = memKeys.subarray(64, 96);
     const idCommitment = memKeys.subarray(96);
-    const idCommitmentBigInt = buildBigIntFromUint8Array(idCommitment);
+    const idCommitmentBigInt = buildBigIntFromUint8Array(idCommitment, 96);
 
     return new IdentityCredential(
       idTrapdoor,

diff --git a/src/utils/bytes.ts b/src/utils/bytes.ts
@@ -61,9 +61,12 @@ export function writeUIntLE(
  * @param array: Uint8Array
  * @returns BigInt
  */
-export function buildBigIntFromUint8Array(array: Uint8Array): bigint {
+export function buildBigIntFromUint8Array(
+  array: Uint8Array,
+  byteOffset: number = 0
+): bigint {
   const dataView = new DataView(array.buffer);
-  return dataView.getBigUint64(0, true);
+  return dataView.getBigUint64(byteOffset, true);
 }
 
 /**