Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update contract #72

Merged
merged 10 commits into from
Oct 17, 2023
Merged

feat: update contract #72

merged 10 commits into from
Oct 17, 2023

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Oct 14, 2023 •
edited
Loading

@weboko weboko requested a review from rymnc October 14, 2023 20:52
rymnc
rymnc suggested changes Oct 15, 2023
View reviewed changes
Copy link

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR, we need to integrate the registry appropriately

src/constants.ts Outdated Show resolved Hide resolved
src/constants.ts Outdated
"event MemberRegistered(uint256 pubkey, uint256 index)",
"event MemberWithdrawn(uint256 pubkey, uint256 index)",
"function register(uint256[] calldata commitments) external payable",
"event MemberRegistered(uint256 idCommitment, uint256 idCommitmentIndex)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this abi isn't quite right, we now use an rln registry contract, within which we have references to the storage contracts. you would want to first get the usingStorageIndex from the registry contract, then subscribe to MemberRegistered from that contract.
refer to how we do it in nwaku - https://github.com/waku-org/nwaku/blob/2e515a06ed0885a9e2b226a452b36bfdbfef324e/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim#L30-L51 and https://github.com/waku-org/nwaku/blob/2e515a06ed0885a9e2b226a452b36bfdbfef324e/waku/waku_rln_relay/group_manager/on_chain/group_manager.nim#L398-L492

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointers

@weboko weboko requested a review from rymnc October 17, 2023 08:35
rymnc
rymnc approved these changes Oct 17, 2023
View reviewed changes
Copy link

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you tested this e2e perhaps?

@weboko
Copy link
Contributor Author

weboko commented Oct 17, 2023

have you tested this e2e perhaps

on my local setup, next step is to integrate into rln-js example together wit keystore of course 🙏

@weboko weboko merged commit 5b9414a into master Oct 17, 2023
4 of 5 checks passed
@weboko weboko deleted the weboko/update-contract branch October 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: update to latest contract per rfc
2 participants
@weboko @rymnc