chore: prevent unchecked index access

karma.conf.cjs

@@ -1,49 +1,58 @@
 const webpack = require("webpack");
-const playwright = require('playwright');
+const playwright = require("playwright");
 
 process.env.CHROME_BIN = playwright.chromium.executablePath();
 process.env.FIREFOX_BIN = playwright.firefox.executablePath();
 
+const path = require("path");
+const tsConfigFile = path.resolve(__dirname, "./tsconfig.dev.json");
+
 module.exports = function (config) {
   config.set({
     frameworks: ["webpack", "mocha"],
     files: ["src/**/!(node).spec.ts"],
     preprocessors: {
-      "src/**/!(node).spec.ts": ["webpack"]
+      "src/**/!(node).spec.ts": ["webpack"],
     },
     envPreprocessor: ["CI"],
     reporters: ["progress"],
     browsers: ["ChromeHeadless", "FirefoxHeadless"],
     singleRun: true,
     client: {
       mocha: {
-        timeout: 6000 // Default is 2s
-      }
+        timeout: 6000, // Default is 2s
+      },
     },
     webpack: {
       mode: "development",
       module: {
-        rules: [{ test: /\.([cm]?ts|tsx)$/, loader: "ts-loader" }]
+        rules: [
+          {
+            test: /\.([cm]?ts|tsx)$/,
+            loader: "ts-loader",
+            options: { configFile: tsConfigFile },
+          },
+        ],
       },
       plugins: [
         new webpack.DefinePlugin({
           "process.env.CI": process.env.CI || false,
           "process.env.DISPLAY": "Browser",
         }),
         new webpack.ProvidePlugin({
-          process: "process/browser.js"
-        })
+          process: "process/browser.js",
+        }),
       ],
       resolve: {
         extensions: [".ts", ".tsx", ".js"],
         extensionAlias: {
           ".js": [".js", ".ts"],
           ".cjs": [".cjs", ".cts"],
-          ".mjs": [".mjs", ".mts"]
-        }
+          ".mjs": [".mjs", ".mts"],
+        },
       },
       stats: { warnings: false },
-      devtool: "inline-source-map"
-    }
+      devtool: "inline-source-map",
+    },
   });
 };

package.json

@@ -29,9 +29,9 @@
     "check": "run-s check:*",
     "check:workspaces": "npm run check --workspaces --if-present",
     "check:ws": "[ $(ls -1 ./packages|wc -l) -eq $(cat package.json | jq '.workspaces | length') ] || exit 1 # check no packages left behind",
-    "test": "NODE_ENV=test npm run test --workspaces --if-present",
-    "test:browser": "NODE_ENV=test npm run test:browser --workspaces --if-present",
-    "test:node": "NODE_ENV=test npm run test:node --workspaces --if-present",
+    "test": "npm run test --workspaces --if-present",
+    "test:browser": "npm run test:browser --workspaces --if-present",
+    "test:node": "npm run test:node --workspaces --if-present",
     "proto": "npm run proto --workspaces --if-present",
     "deploy": "node ci/deploy.js",
     "doc": "run-s doc:*",

packages/core/package.json

@@ -57,12 +57,12 @@
     "fix": "run-s fix:*",
     "fix:lint": "eslint src *.js --fix",
     "check": "run-s check:*",
-    "check:tsc": "tsc -p tsconfig.dev.json",
+    "check:tsc": "tsc -p tsconfig.json",
     "check:lint": "eslint src *.js",
     "check:spelling": "cspell \"{README.md,src/**/*.ts}\"",
-    "test": "NODE_ENV=test run-s test:*",
+    "test": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json run-s test:*",
     "test:node": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json mocha",
-    "test:browser": "NODE_ENV=test karma start karma.conf.cjs",
+    "test:browser": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json karma start karma.conf.cjs",
     "watch:build": "tsc -p tsconfig.json -w",
     "watch:test": "mocha --watch",
     "prepublish": "npm run build",

packages/core/src/lib/filter/index.ts

@@ -110,7 +110,7 @@ class Subscription {
           async (source) => await all(source)
         );
 
-        if (!res || !res.length) {
+        if (!res?.[0]) {
           throw Error(
             `No response received for request ${request.requestId}: ${res}`
           );
@@ -203,7 +203,7 @@ class Subscription {
           async (source) => await all(source)
         );
 
-        if (!res || !res.length) {
+        if (!res?.[0]) {
           throw Error(
             `No response received for request ${request.requestId}: ${res}`
           );
@@ -246,7 +246,7 @@ class Subscription {
           async (source) => await all(source)
         );
 
-        if (!res || !res.length) {
+        if (!res?.[0]) {
           throw Error(
             `No response received for request ${request.requestId}: ${res}`
           );

packages/core/src/lib/filterPeers.ts

@@ -43,7 +43,10 @@ export function filterPeersByDiscovery(
   // Fill up to numPeers with remaining random peers if needed
   while (selectedPeers.length < numPeers && nonBootstrapPeers.length > 0) {
     const randomIndex = Math.floor(Math.random() * nonBootstrapPeers.length);
-    const randomPeer = nonBootstrapPeers.splice(randomIndex, 1)[0];
+    const randomPeer = nonBootstrapPeers[randomIndex];
+    if (!randomPeer) {
+      continue;
+    }
     selectedPeers.push(randomPeer);
   }
 

packages/core/src/lib/store/index.ts

@@ -237,9 +237,12 @@ class Store extends BaseProtocol implements IStore {
       );
     }
 
-    // we can be certain that there is only one pubsub topic in the query
     const pubsubTopicForQuery = uniquePubsubTopicsInQuery[0];
 
+    if (!pubsubTopicForQuery) {
+      throw Error("Cannot find a pubsub topic to use for query.");
+    }
+
     ensurePubsubTopicIsConfigured(pubsubTopicForQuery, this.pubsubTopics);
 
     // check that the pubsubTopic from the Cursor and Decoder match
@@ -287,6 +290,10 @@ class Store extends BaseProtocol implements IStore {
       })
     )[0];
 
+    if (!peer) {
+      throw Error("Failed executing query: missing a peer.");
+    }
+
     for await (const messages of paginate<T>(
       this.getStream.bind(this, peer),
       queryOpts,

packages/core/src/lib/wait_for_remote_peer.ts

@@ -89,7 +89,7 @@
 
   if (peers.length) {
     if (!metadataService) {
-      log.info(`${codec} peer found: `, peers[0].id.toString());
+      log.info(`${codec} peer found: `, peers[0]?.id.toString());
       return;
     }
 
@@ -100,7 +100,7 @@
       );
       return;
     } catch (e) {
       if ((e as any).code === "ERR_CONNECTION_BEING_CLOSED")
         log.error(
           `Connection with the peer was closed and possibly because it's on a different shard. Error: ${e}`
         );

packages/dns-discovery/package.json

@@ -40,12 +40,12 @@
     "check": "run-s check:*",
     "check:lint": "eslint src --ext .ts",
     "check:spelling": "cspell \"{README.md,src/**/*.ts}\"",
-    "check:tsc": "tsc -p tsconfig.dev.json",
+    "check:tsc": "tsc -p tsconfig.json",
     "prepublish": "npm run build",
     "reset-hard": "git clean -dfx -e .idea && git reset --hard && npm i && npm run build",
-    "test": "NODE_ENV=test run-s test:*",
+    "test": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json run-s test:*",
     "test:node": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json mocha",
-    "test:browser": "NODE_ENV=test karma start karma.conf.cjs"
+    "test:browser": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json karma start karma.conf.cjs"
   },
   "engines": {
     "node": ">=18"

packages/dns-discovery/src/dns.ts

@@ -8,7 +8,7 @@ import type {
 import { Logger } from "@waku/utils";
 
 import { DnsOverHttps } from "./dns_over_https.js";
-import { ENRTree } from "./enrtree.js";
+import { ENRTree, ENRTreeValues } from "./enrtree.js";
 import {
   fetchNodesUntilCapabilitiesFulfilled,
   yieldNodesUntilCapabilitiesFulfilled
@@ -41,8 +41,7 @@ export class DnsNodeDiscovery {
     enrTreeUrls: string[],
     wantedNodeCapabilityCount: Partial<NodeCapabilityCount>
   ): Promise<IEnr[]> {
-    const networkIndex = Math.floor(Math.random() * enrTreeUrls.length);
-    const { publicKey, domain } = ENRTree.parseTree(enrTreeUrls[networkIndex]);
+    const { publicKey, domain } = DnsNodeDiscovery.parseTree(enrTreeUrls);
     const context: SearchContext = {
       domain,
       publicKey,
@@ -78,8 +77,7 @@ export class DnsNodeDiscovery {
     enrTreeUrls: string[],
     wantedNodeCapabilityCount: Partial<NodeCapabilityCount>
   ): AsyncGenerator<IEnr> {
-    const networkIndex = Math.floor(Math.random() * enrTreeUrls.length);
-    const { publicKey, domain } = ENRTree.parseTree(enrTreeUrls[networkIndex]);
+    const { publicKey, domain } = DnsNodeDiscovery.parseTree(enrTreeUrls);
     const context: SearchContext = {
       domain,
       publicKey,
@@ -149,8 +147,9 @@ export class DnsNodeDiscovery {
     subdomain: string,
     context: SearchContext
   ): Promise<string> {
-    if (this._DNSTreeCache[subdomain]) {
-      return this._DNSTreeCache[subdomain];
+    const currentCache = this._DNSTreeCache[subdomain];
+    if (currentCache) {
+      return currentCache;
     }
 
     // Location is either the top level tree entry host or a subdomain of it.
@@ -161,9 +160,13 @@ export class DnsNodeDiscovery {
 
     const response = await this.dns.resolveTXT(location);
 
-    if (!response.length)
+    if (!response.length) {
       throw new Error("Received empty result array while fetching TXT record");
-    if (!response[0].length) throw new Error("Received empty TXT record");
+    }
+
+    if (!response[0]?.length) {
+      throw new Error("Received empty TXT record");
+    }
 
     // Branch entries can be an array of strings of comma delimited subdomains, with
     // some subdomain strings split across the array elements
@@ -172,6 +175,17 @@ export class DnsNodeDiscovery {
     this._DNSTreeCache[subdomain] = result;
     return result;
   }
+
+  private static parseTree(enrTreeUrls: string[]): ENRTreeValues {
+    const networkIndex = Math.floor(Math.random() * enrTreeUrls.length);
+    const enrTree = enrTreeUrls[networkIndex];
+
+    if (!enrTree) {
+      throw Error(`Failed to read ENR tree for the network: ${networkIndex}`);
+    }
+
+    return ENRTree.parseTree(enrTree);
+  }
 }
 
 function getEntryType(entry: string): string {
@@ -211,5 +225,5 @@ function selectRandomPath(branches: string[], context: SearchContext): string {
     index = Math.floor(Math.random() * branches.length);
   } while (circularRefs[index]);
 
-  return branches[index];
+  return branches[index] as string;
 }

packages/dns-discovery/src/enrtree.ts

@@ -40,6 +40,10 @@ export class ENRTree {
     // (Trailing recovery bit must be trimmed to pass `ecdsaVerify` method)
     const signedComponent = root.split(" sig")[0];
 
+    if (!signedComponent) {
+      throw Error(`Signature component is missing, got: ${signedComponent}`);
+    }
+
     const signedComponentBuffer = utf8ToBytes(signedComponent);
     const signatureBuffer = fromString(rootValues.signature, "base64url").slice(
       0,
@@ -113,11 +117,18 @@ export class ENRTree {
    * either further branch entries or ENR records.
    */
   static parseBranch(branch: string): string[] {
-    if (!branch.startsWith(this.BRANCH_PREFIX))
-      throw new Error(
+    if (!branch.startsWith(this.BRANCH_PREFIX)) {
+      throw Error(
         `ENRTree branch entry must start with '${this.BRANCH_PREFIX}'`
       );
+    }
+
+    const enrPart = branch.split(this.BRANCH_PREFIX)[1];
+
+    if (!enrPart) {
+      throw Error(`ENRTree branch does not have data`);
+    }
 
-    return branch.split(this.BRANCH_PREFIX)[1].split(",");
+    return enrPart.split(",");
   }
 }

packages/enr/package.json

@@ -40,10 +40,10 @@
     "check": "run-s check:*",
     "check:lint": "eslint src --ext .ts",
     "check:spelling": "cspell \"{README.md,src/**/*.ts}\"",
-    "check:tsc": "tsc -p tsconfig.dev.json",
-    "test": "NODE_ENV=test run-s test:*",
+    "check:tsc": "tsc -p tsconfig.json",
+    "test": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json run-s test:*",
     "test:node": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json mocha",
-    "test:browser": "NODE_ENV=test karma start karma.conf.cjs",
+    "test:browser": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json karma start karma.conf.cjs",
     "prepublish": "npm run build",
     "reset-hard": "git clean -dfx -e .idea && git reset --hard && npm i && npm run build"
   },

packages/enr/src/decoder.ts

@@ -30,7 +30,7 @@ async function fromValues(values: Uint8Array[]): Promise<ENR> {
   const obj: Record<ENRKey, ENRValue> = {};
   for (let i = 0; i < kvs.length; i += 2) {
     try {
-      obj[bytesToUtf8(kvs[i])] = kvs[i + 1];
+      obj[bytesToUtf8(kvs[i] as Uint8Array)] = kvs[i + 1] as Uint8Array;
     } catch (e) {
       log.error("Failed to decode ENR key to UTF-8, skipping it", kvs[i], e);
     }

packages/enr/src/enr.ts

@@ -73,25 +73,23 @@ export class ENR extends RawEnr implements IEnr {
 
   setLocationMultiaddr(multiaddr: Multiaddr): void {
     const protoNames = multiaddr.protoNames();
-    if (
-      protoNames.length !== 2 &&
-      protoNames[1] !== "udp" &&
-      protoNames[1] !== "tcp"
-    ) {
+    const protocol = protoNames[1];
+    if (protoNames.length !== 2 && protocol !== "udp" && protocol !== "tcp") {
       throw new Error("Invalid multiaddr");
     }
+
     const tuples = multiaddr.tuples();
-    if (!tuples[0][1] || !tuples[1][1]) {
+    if (!tuples[0]?.[1] || !tuples[1]?.[1] || !protocol) {
       throw new Error("Invalid multiaddr");
     }
 
     // IPv4
     if (tuples[0][0] === 4) {
       this.set("ip", tuples[0][1]);
-      this.set(protoNames[1], tuples[1][1]);
+      this.set(protocol, tuples[1][1]);
     } else {
       this.set("ip6", tuples[0][1]);
-      this.set(protoNames[1] + "6", tuples[1][1]);
+      this.set(protocol + "6", tuples[1][1]);
     }
   }
 

packages/enr/src/raw_enr.ts

@@ -153,7 +153,7 @@ export class RawEnr extends Map<ENRKey, ENRValue> {
    */
   get waku2(): Waku2 | undefined {
     const raw = this.get("waku2");
-    if (raw) return decodeWaku2(raw[0]);
+    if (raw) return decodeWaku2(raw[0] as number);
 
     return;
   }

packages/interfaces/package.json

@@ -39,7 +39,7 @@
     "check": "run-s check:*",
     "check:lint": "eslint src",
     "check:spelling": "cspell \"{README.md,src/**/*.ts}\"",
-    "check:tsc": "tsc -p tsconfig.dev.json",
+    "check:tsc": "tsc -p tsconfig.json",
     "prepublish": "npm run build",
     "reset-hard": "git clean -dfx -e .idea && git reset --hard && npm i && npm run build"
   },

packages/message-encryption/package.json

@@ -61,10 +61,10 @@
     "check": "run-s check:*",
     "check:lint": "eslint src *.js",
     "check:spelling": "cspell \"{README.md,src/**/*.ts}\"",
-    "check:tsc": "tsc -p tsconfig.dev.json",
-    "test": "NODE_ENV=test run-s test:*",
+    "check:tsc": "tsc -p tsconfig.json",
+    "test": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json run-s test:*",
     "test:node": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json mocha",
-    "test:browser": "NODE_ENV=test karma start karma.conf.cjs",
+    "test:browser": "NODE_ENV=test TS_NODE_PROJECT=./tsconfig.dev.json karma start karma.conf.cjs",
     "prepublish": "npm run build",
     "reset-hard": "git clean -dfx -e .idea && git reset --hard && npm i && npm run build"
   },