Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: changing default pubsub topic to its static sharding version #2083

Merged
merged 17 commits into from
Jul 25, 2024
Merged

chore: changing default pubsub topic to its static sharding version #2083

merged 17 commits into from
Jul 25, 2024

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Jul 24, 2024 •
edited by weboko
Loading

Problem

After deprecating named sharding in nwaku, the pubsub topic /waku/2/default-waku/proto is no longer valid. We are migrating the default to/waku/2/rs/0/0 for tests and shard info for TWN (see #2085).

Nwaku nodes weren't starting in some interop tests because of being set up with this no longer valid pubsub topic.

Similarly, as metadata protocol was recently activated for cluster 0, updated some tests in which clusters and shards weren't consistent between nodes, which led to disconnections.

Related to waku-org/nwaku#2621

Includes: #2085

@gabrielmer gabrielmer requested a review from a team as a code owner July 24, 2024 09:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 118.95 KB (+0.02% 🔺) 2.4 s (+0.02% 🔺) 17.2 s (+100.2% 🔺) 19.6 s
Waku Simple Light Node 183.69 KB (-0.05% 🔽) 3.7 s (-0.05% 🔽) 19.7 s (-10.23% 🔽) 23.3 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 2.2 s (-60.04% 🔽) 2.7 s
Symmetric encryption 22.6 KB (+0.07% 🔺) 452 ms (+0.07% 🔺) 6.1 s (+40.73% 🔺) 6.5 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 10 s (+1.65% 🔺) 11.4 s
Peer Exchange discovery 74.22 KB (0%) 1.5 s (0%) 13 s (-25.01% 🔽) 14.5 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 11.9 s (-16.44% 🔽) 13.3 s
Privacy preserving protocols 38.9 KB (+0.08% 🔺) 778 ms (+0.08% 🔺) 7.9 s (-17.31% 🔽) 8.7 s
Waku Filter 113.31 KB (0%) 2.3 s (0%) 14.9 s (-21.06% 🔽) 17.1 s
Waku LightPush 111.31 KB (0%) 2.3 s (0%) 14.1 s (-19.3% 🔽) 16.4 s
History retrieval protocols 111.81 KB (0%) 2.3 s (0%) 12.5 s (+1.42% 🔺) 14.8 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 2.5 s (+32.48% 🔺) 2.6 s

weboko
weboko reviewed Jul 24, 2024
View reviewed changes
packages/core/CHANGELOG.md Outdated Show resolved Hide resolved
@weboko
Copy link
Collaborator

weboko commented Jul 24, 2024

Thank you @gabrielmer for opening the PR!

We are trying to remove named sharding so that pubsub as a parameter will be deprecated

fyi @vpavlin @waku-org/js-waku-developers

@gabrielmer gabrielmer marked this pull request as draft July 25, 2024 08:40
@gabrielmer
Copy link
Contributor Author

Moving PR to draft until some other issues are addressed

@gabrielmer gabrielmer self-assigned this Jul 25, 2024
@gabrielmer
Copy link
Contributor Author

All tests passed 🥳

@gabrielmer gabrielmer marked this pull request as ready for review July 25, 2024 15:50
danisharora099
danisharora099 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is awesome! Thanks for the effort!
Super happy to see all CI green :D

Approving but leaving one quick point about defaulting the pubsub topic/shard info to the new DefaultPubsubTopic if no shardInfo is passed to createLightNode

packages/tests/tests/wait_for_remote_peer.node.spec.ts Show resolved Hide resolved
@weboko
feat: create default shard info, update tests (#2085)
4c74446 
* feat: create default shard info, update tests

* add link

* fix tests

* remoe only

* up tests

* up test
@weboko weboko merged commit 08fc2d1 into master Jul 25, 2024
12 checks passed
@weboko weboko deleted the chore-deprecating-named-sharding branch July 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weboko weboko weboko left review comments

@danisharora099 danisharora099 danisharora099 approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@gabrielmer gabrielmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmer @weboko @danisharora099