Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): decouple reliability logic into a separate class #2100

Closed
wants to merge 2 commits into from

Conversation

danisharora099
Copy link
Collaborator

Problem

Based on #2075, the logic to detect messages that were missed from the Filter protocol were being detected inside of the Filter SDK implementation. This leads to a tight couple of primary objective of FilterSDK, and reliability goals.

This obstacle also extends to adding further actions that might be taken with additional protocols such as Store pings, and LightPush retries for certain messages.

Solution

Decouple reliability logic into a new ReliabilityMonitor class.

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

Copy link

github-actions bot commented Aug 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.57 KB (-0.04% 🔽) 1.8 s (-0.04% 🔽) 2.6 s (+14.98% 🔺) 4.4 s
Waku Simple Light Node 154.21 KB (+0.01% 🔺) 3.1 s (+0.01% 🔺) 2.6 s (-20.04% 🔽) 5.7 s
ECIES encryption 22.83 KB (0%) 457 ms (0%) 821 ms (+28.84% 🔺) 1.3 s
Symmetric encryption 22.33 KB (0%) 447 ms (0%) 746 ms (-4.27% 🔽) 1.2 s
DNS discovery 72.26 KB (0%) 1.5 s (0%) 1.7 s (-17.84% 🔽) 3.2 s
Peer Exchange discovery 73.79 KB (0%) 1.5 s (0%) 2.9 s (+85.29% 🔺) 4.4 s
Local Peer Cache Discovery 67.57 KB (0%) 1.4 s (0%) 1.9 s (-0.62% 🔽) 3.3 s
Privacy preserving protocols 38.92 KB (0%) 779 ms (0%) 899 ms (+53.99% 🔺) 1.7 s
Waku Filter 81.02 KB (+0.03% 🔺) 1.7 s (+0.03% 🔺) 2.5 s (+42.8% 🔺) 4.2 s
Waku LightPush 78.63 KB (+0.04% 🔺) 1.6 s (+0.04% 🔺) 2.6 s (+86.16% 🔺) 4.2 s
History retrieval protocols 79.05 KB (+0.04% 🔺) 1.6 s (+0.04% 🔺) 1.5 s (-32.17% 🔽) 3.1 s
Deterministic Message Hashing 7.31 KB (0%) 147 ms (0%) 222 ms (-56.4% 🔽) 368 ms

@danisharora099
Copy link
Collaborator Author

superseded by #2105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: message verification and retry
1 participant