feat: lighten retry logic for LightPush #2182

weboko · 2024-10-11T17:54:25Z

Problem

LightPush doesn't use autoRetry in current version.

Add it and simplify

github-actions · 2024-10-11T17:58:26Z

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
Waku node	85.36 KB (-0.12% 🔽)	1.8 s (-0.12% 🔽)	18.7 s (+40.79% 🔺)	20.4 s
Waku Simple Light Node	137.3 KB (-0.15% 🔽)	2.8 s (-0.15% 🔽)	13 s (-35.6% 🔽)	15.7 s
ECIES encryption	22.88 KB (0%)	458 ms (0%)	3.6 s (-14.35% 🔽)	4.1 s
Symmetric encryption	22.37 KB (0%)	448 ms (0%)	7 s (+108.2% 🔺)	7.5 s
DNS discovery	72.9 KB (0%)	1.5 s (0%)	15 s (+71.88% 🔺)	16.5 s
Peer Exchange discovery	74.1 KB (0%)	1.5 s (0%)	10.6 s (+66.54% 🔺)	12.1 s
Local Peer Cache Discovery	68.03 KB (0%)	1.4 s (0%)	10.2 s (-2.6% 🔽)	11.5 s
Privacy preserving protocols	76.02 KB (+0.04% 🔺)	1.6 s (+0.04% 🔺)	8.1 s (-26.49% 🔽)	9.6 s
Waku Filter	79.62 KB (-0.16% 🔽)	1.6 s (-0.16% 🔽)	12.5 s (+5.84% 🔺)	14.1 s
Waku LightPush	75.03 KB (-3.54% 🔽)	1.6 s (-3.54% 🔽)	13.4 s (+51.26% 🔺)	14.9 s
History retrieval protocols	77.1 KB (+0.07% 🔺)	1.6 s (+0.07% 🔺)	13.4 s (-13.64% 🔽)	14.9 s
Deterministic Message Hashing	7.39 KB (0%)	148 ms (0%)	2.8 s (+160.84% 🔺)	2.9 s

weboko · 2024-10-11T21:30:56Z

packages/sdk/src/protocols/light_push/light_push.ts


-  private readonly reliabilityMonitor: SenderReliabilityMonitor;
+export class LightPush implements ILightPush {


removed BaseProtocolSDK for now as it is not used
let's follow up in #2075

feat: lighten retry logic for LightPush

771440c

weboko requested a review from a team as a code owner October 11, 2024 17:54

weboko added 2 commits October 11, 2024 21:55

update tests

92d0a28

remove base protocol sdk from light push, add unit tests for light push

9d1afd7

weboko commented Oct 11, 2024

View reviewed changes

remove replaced test

9ec36c3

weboko marked this pull request as draft October 11, 2024 22:20


		private readonly reliabilityMonitor: SenderReliabilityMonitor;
		export class LightPush implements ILightPush {