fix min-max check in membership initializer

waku-org · Sep 25, 2024 · 5181d2d · 5181d2d
1 parent bd92aad
commit 5181d2d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Membership.sol b/src/Membership.sol
@@ -134,9 +134,9 @@ abstract contract MembershipUpgradeable is Initializable {
         internal
         onlyInitializing
     {
-        require(_maxTotalRateLimit >= maxMembershipRateLimit);
-        require(_maxMembershipRateLimit > minMembershipRateLimit); // FIXME: > or >=?
-        require(_minMembershipRateLimit > 0);
+        require(0 < _minMembershipRateLimit);
+        require(_minMembershipRateLimit <= _maxMembershipRateLimit); // FIXME: < or <=?
+        require(_maxMembershipRateLimit <= _maxTotalRateLimit);
         require(_activeStateDuration > 0); // FIXME: also _gracePeriodDuration > 0?
 
         priceCalculator = IPriceCalculator(_priceCalculator);