feat: deploy to Linea #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-ramos
commented
Oct 1, 2024
•
richard-ramos
commented
- Splits deployment script in separate deployments per contract (since we might want in the future to deploy different PriceCalculators or WakuRLNV2 contracts).
- Adds https://github.com/Cyfrin/foundry-devops to retrieve the latest address deployed. (Useful when using multiple scripts)
- Adds separate package.json scripts to control the deployment of each individual contract
- Setups the deployment for Linea Sepolia
improve terminology consistency and minor refactoring
richard-ramos
force-pushed
the
linea
branch
2 times, most recently
from
38181df
to
da65355
Compare
richard-ramos
force-pushed
the
linea
branch
5 times, most recently
from
bd9bb06
to
38783cf
Compare
0x-r4bbit
reviewed
Oct 7, 2024
script/Deploy.s.sol
Outdated
|
|
||
| function run() public broadcast returns (address) { | ||
| address priceCalcAddr = DevOpsTools.get_most_recent_deployment("LinearPriceCalculator", block.chainid); | ||
| address wakuRlnV2ImplAddr = DevOpsTools.get_most_recent_deployment("WakuRlnV2", block.chainid); |
There was a problem hiding this comment.
This is cool, but what happens when you don't have a broadcast directory with a previous deployment on your machine?
There was a problem hiding this comment.
Hm, good point.
I'll change the script to allow the usage of environment variables and/or indicate you want to use the broadcast directory.
There was a problem hiding this comment.
Change implemented in a5acb1d
Now it will by default use the broadcast dir, unless env variables are used for contracts that were already deployed.
* refactor, minor fixes * do not reset ongoing grace period on extension (cf. spec change) * minor renaming, comments * refactor, group functions by funcitonality * extract membership expiration calculation to internal function * save active duration per membership (must carry over after extension) * optional lazy erasure from membership set * minor fixes in tests * fix: off-by-one: end index can't be equal to next free index * minor refactoring, comments * define period boundaries: start inclusive, end exclusive * separate eraseMembership functions to user-focused (lazy) and admin-focused (tree cleanup) * minor fix to maintain line lengths * unify membership-related events * add test for zero grace period * fix typo in comment Co-authored-by: richΛrd <[email protected]> --------- Co-authored-by: richΛrd <[email protected]>
richard-ramos
force-pushed
the
feat/membership-notrack
branch
4 times, most recently
from
2b1600a
to
6db38e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.