Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 GitHub action for pylint is broken #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jaredb1011
Copy link
Contributor

I've reverted back to just installing deps with pip instead of setting up the entire conda environment in the action.

A couple issues remain:

  1. Pylint doesn't resolve imports for our code files located in the repo (cannot import 'common' for example).
  2. PaddleOCR isn't building with pip.
  3. We have some general exceptions really should be more specific in link_retrieval.py, but I'm not sure if we've been able to properly test against the waldo API to see what errors are returned that need to be caught.

@jaredb1011 jaredb1011 added this to the Data Pre-processing milestone May 6, 2023
@jaredb1011 jaredb1011 requested a review from Joe-TheBro May 6, 2023 15:18
@jaredb1011 jaredb1011 self-assigned this May 6, 2023
@jaredb1011 jaredb1011 linked an issue May 6, 2023 that may be closed by this pull request
Copy link
Contributor

@Joe-TheBro Joe-TheBro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good for right now.

  1. Don't have a fix in mind.
  2. When I worked with PaddleOCR and created that file, I had to create a separate environment because PaddleOCR has some unique quirks and runs on a different version of Python.
  3. I have not been able to test for the exceptions, I added them to have them in place as a means of safety in case something breaks, and we don't know what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

github action for pylint is broken
2 participants