Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout and stop using <form> #13

Closed
wants to merge 1 commit into from
Closed

Fix layout and stop using <form> #13

wants to merge 1 commit into from

Conversation

waldyrious
Copy link
Owner

Split from #6. Depends on #6 and #12 being merged first.

@waldyrious
Copy link
Owner Author

waldyrious commented Dec 12, 2022

Hmm, some seems to be off:

Firefox

Before this PR With this PR
firefox-before firefox-after

Chromium (Brave)

Before this PR With this PR
brave-before brave-after

Since I've rebased the branch following the merge of #6 and #12, and fixed conflicts in the CSS file (by accepting all your changes), but the contents of the CSS file before and after the rebase appear to be the same.

Maybe I messed something up with the rebases? WDYT @not-my-profile?

@waldyrious waldyrious marked this pull request as ready for review December 12, 2022 01:31
@waldyrious
Copy link
Owner Author

Note: I've submitted #14 as an alternative approach to the layout changes done in this PR.

@waldyrious
Copy link
Owner Author

Per agreement via Matrix chat, I'm closing this PR in favor of #14. (The "run" button will be removed later, btw — see #16.)

@waldyrious waldyrious closed this Dec 17, 2022
@waldyrious waldyrious deleted the layout branch December 17, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants