Fix: TypeError: Cannot use 'in' operator to search for 'updatedAt' in…

… undefined (#2113) * Fix: TypeError: Cannot use 'in' operator to search for 'updatedAt' in undefined Revert: Remove 'updateAt' property in leancloud update. (#2108) * chore: use for...in replace hasOwnProperty --------- Co-authored-by: Austin Lee <[email protected]>
walinejs · Oct 10, 2023 · da7e95f · da7e95f · Mejituu · Oct 10, 2023
1 parent 616499a
commit da7e95f
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/packages/server/src/service/storage/leancloud.js b/packages/server/src/service/storage/leancloud.js
@@ -405,15 +405,16 @@ module.exports = class extends Base {
       ret.map(async (item) => {
         const _oldStatus = item.get('status');
 
-        var newData
-        if (think.isFunction(data)) {
-          newData = data(item.toJSON())
-        }
-        if ('updatedAt' in newData) {
-          delete newData.updatedAt
-        }
-        item.set(newData)
+        var updateData = typeof data === 'function' ? data(item.toJSON()) : data;
 
+        const REVERSED_KEYS = ['createdAt', 'updatedAt'];
+        for (const k in updateData) {
+          if (REVERSED_KEYS.includes(k)) {
+            continue;
+          }
+          instance.set(k, updateData[k]);
+        }
+
         const _newStatus = item.get('status');
 
         if (_newStatus && _oldStatus !== _newStatus) {