Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to delete all comments for given path #2129

Closed
wants to merge 1 commit into from
Closed

Add ability to delete all comments for given path #2129

wants to merge 1 commit into from

Conversation

slavoyar
Copy link

  1. Add delete method for article. It deletes all comments for given path.
  2. Update en docs.

@lizheming
Copy link
Collaborator

Hi slavoyar, thank you very much for your work. I don't have any problems with the demand, but I have a few small opinions on the implementation.

Our API follows the RESTful principle. The /comment interface is used to operate the comment resource table, and the /article interface is used to operate the articles resource table. However, now the article resource table only has statistical functions, so it is called count name.

So if you want to add an interface to delete all comments, I think it is more appropriate to add it to DELETE /comment. What do you think?

@slavoyar
Copy link
Author

Hi slavoyar, thank you very much for your work. I don't have any problems with the demand, but I have a few small opinions on the implementation.

Our API follows the RESTful principle. The /comment interface is used to operate the comment resource table, and the /article interface is used to operate the articles resource table. However, now the article resource table only has statistical functions, so it is called count name.

So if you want to add an interface to delete all comments, I think it is more appropriate to add it to DELETE /comment. What do you think?

@lizheming Yes, this make sense to me. I will move this logic to comment controller.

@slavoyar slavoyar closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants