Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): update sass functions to use new module syntax #2784

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

mapxn
Copy link
Contributor

@mapxn mapxn commented Oct 27, 2024

  • Replace str-index with string.index
  • Replace str-slice with string.slice
  • Replace str-length with string.length

These changes address deprecation warnings from Dart Sass 3.0.0

- Replace str-index with string.index
- Replace str-slice with string.slice
- Replace str-length with string.length

These changes address deprecation warnings from Dart Sass 3.0.0
@mapxn
Copy link
Contributor Author

mapxn commented Oct 27, 2024

Fix the following warnings:

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.index instead.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
24 │   @if not str-index($svg, xmlns) {
   │           ^^^^^^^^^^^^^^^^^^^^^^
   ╵
    src/styles/helpers/_svg.scss 24:11  svg-url()
    src/styles/helpers/_svg.scss 48:21  background-svg()
    src/styles/meta.scss 31:5           root stylesheet

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.slice instead.

More info and automated migrator: https://sass-lang.com/d/import

  ╷
8 │     str-slice($string, 1, $index - 1) + $replace +
  │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
    src/styles/helpers/_svg.scss 8:5    string-replace()
    src/styles/helpers/_svg.scss 25:11  svg-url()
    src/styles/helpers/_svg.scss 48:21  background-svg()
    src/styles/meta.scss 31:5           root stylesheet

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.length instead.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
10 │         str-slice($string, $index + str-length($search)),
   │                                     ^^^^^^^^^^^^^^^^^^^
   ╵
    src/styles/helpers/_svg.scss 10:37  string-replace()
    src/styles/helpers/_svg.scss 25:11  svg-url()
    src/styles/helpers/_svg.scss 48:21  background-svg()
    src/styles/meta.scss 31:5           root stylesheet

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use string.slice instead.

More info and automated migrator: https://sass-lang.com/d/import

   ╷
10 │         str-slice($string, $index + str-length($search)),
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    src/styles/helpers/_svg.scss 10:9   string-replace()
    src/styles/helpers/_svg.scss 25:11  svg-url()
    src/styles/helpers/_svg.scss 48:21  background-svg()
    src/styles/meta.scss 31:5           root stylesheet

@lizheming lizheming merged commit 5982545 into walinejs:main Oct 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants