Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] show tags in list item view #594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Strubbl
Copy link
Contributor

@Strubbl Strubbl commented Jun 30, 2017

Currently i am working on displaying the article's tags in the list of the articles. This implementation is not finished yet.

I pushed it here to save my work. And i hope that some is willing to give some input or add some code to improve this feature.

Currently open task for this feature from my point of view:

  • fix CI error
  • clean up code (check if areTagsAdded is really needed)
  • use case: see list of articles, open one to read, edit its tags, go back to list of articles. Problem: list of articles has still old status of tags
  • support theming of the tags
  • change tag font color to the same of the url below them

Current status of implementation:

screenshot_20170630-203015

@ngosang
Copy link
Contributor

ngosang commented Sep 9, 2017

@Strubbl I will love that feature, please continue your work when you have free time.

@Strubbl
Copy link
Contributor Author

Strubbl commented Sep 9, 2017

I am not going to finish this soon. I was on business trips in past and i am going to be on business trips the upcoming weeks, too. Therefore i do not have an android dev machine with me.
If anybody wants to help, feel free to add commits to this PR. I just rebased it to latest master.

@di72nn
Copy link
Member

di72nn commented Sep 10, 2017

I'd like to see that feature done, but I think we need to implement async lists loading first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants