-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive icon support #714
base: master
Are you sure you want to change the base?
Adaptive icon support #714
Conversation
The build fails because it can't find As far as I understand it, the different resource folders are only ever used to provide a different icon for the debug flavour. What about unifying all those, and specifying the right app icon to be used in gradle? |
I would like to hear what the devs think about this. Should I move the mipmap folder or would it be a better solution to clean up the folder structure? |
@Strubbl any thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it very much, that you give credits to Michael in the Readme.
I like the approach @Nuntius0 is describing. A cleanup of the folder struture w.r.t. the icons sounds good to me.
Let's go for that. 👍
This adds the new icon from #638 but now with support for adaptive icons on devices running Android 8.0 or higher. The new icon in the shape of a rounded square is used as the legacy icon to be shown on devices running older versions of Android.
The icons have been moved from the
drawables
directories tomipmap
directories as recommended here.This is what the new icon looks like on legacy devices:
The adaptive icon looks different depending upon the mask used by the launcher or selected by the user:
As discussed earlier, we'll need to add credits for Michael Cook in About.
I hope it is okay to have updated the readme icon as well in this same PR.
We will need to build against SDK 26 in order to support adaptive icons though we don't need to target API 26.