Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some bugs in the pintool #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed some bugs in the pintool #4

wants to merge 3 commits into from

Conversation

sam-b
Copy link
Contributor

@sam-b sam-b commented May 5, 2015

Fixed formatting and start up memory allocation issues.

@BestPig
Copy link
Contributor

BestPig commented May 5, 2015

Record variable should be set to true if the binary has no main symbol otherwise stripped binary cannot be monitored properly.

On OS X, the symbol is _main instead of main like others.

@sam-b
Copy link
Contributor Author

sam-b commented May 5, 2015

Good point on the first - will edit tomorrow morning and add in the OSX option.

@sam-b
Copy link
Contributor Author

sam-b commented May 6, 2015

@BestPig Updated the pull request to fix these- thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-b @BestPig