feat!: use uint64 IDs for Keychains and Spaces #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
protocol
sdk-module
docs
spaceward
go-client
test
keychain
labels
Pitasi
force-pushed
the
remove-keychain-space-addresses
branch
from
6f636a5
to
2e9ff2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the SHA256 hash of a numeric sequence (truncated to 8 bytes) and encoded as bech32 to generate addresses like
wardenspace1234andwardenkeyring1234.This PR simplify and cleans up all of this, to only store the actual numeric sequence on-chain.
The frontends are free to represent these IDs as they like.
Simplifying this code on-chain is best for saving some disk space (uint64 are much smaller than the full bech32 string, this applies to the Keychain and Space entities, but also to all the other transactions that were referring to them such as MsgNewKeyRequest), gas, and as a benefit we also don't have to deal with hash collisions.
BREAKING CHANGE: we're in early stage and I won't migrate the old IDs into the new format. It's just easier to start new chains from scratch.