#730 x/act rename rule to template
#827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set expressions within MsgNewAction handling. - Update registry initialization in space module, add missing rule ids
- UpdateSpace - UpdateKey
…o-template-1 # Conflicts: # CHANGELOG.md # api/warden/act/v1beta1/events.pulsar.go # api/warden/act/v1beta1/query.pulsar.go # api/warden/act/v1beta1/tx.pulsar.go # api/warden/warden/v1beta3/events.pulsar.go # api/warden/warden/v1beta3/key.pulsar.go # api/warden/warden/v1beta3/space.pulsar.go # api/warden/warden/v1beta3/tx.pulsar.go # proto/warden/warden/v1beta3/events.proto # proto/warden/warden/v1beta3/key.proto # proto/warden/warden/v1beta3/space.proto # proto/warden/warden/v1beta3/tx.proto # tests/cases/approve_any_3_action.go # tests/cases/owner_approve_action.go # warden/x/act/keeper/actions.go # warden/x/act/keeper/msg_server_new_action.go # warden/x/act/keeper/query_rules.go # warden/x/act/types/v1beta1/errors.go # warden/x/act/types/v1beta1/events.pb.go # warden/x/act/types/v1beta1/query.pb.go # warden/x/act/types/v1beta1/registry.go # warden/x/act/types/v1beta1/tx.pb.go # warden/x/warden/keeper/msg_server_update_key.go # warden/x/warden/keeper/rules.go # warden/x/warden/types/v1beta3/events.pb.go # warden/x/warden/types/v1beta3/key.pb.go # warden/x/warden/types/v1beta3/space.go # warden/x/warden/types/v1beta3/space.pb.go # warden/x/warden/types/v1beta3/tx.pb.go
|
Caution Review failedThe pull request is closed. WalkthroughWalkthroughThe recent update involves a comprehensive renaming within the action module, changing the term Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Check the |
|
|
artur-abliazimov
assigned artur-abliazimov and backsapc and unassigned artur-abliazimov
| if err = k.actKeeper.IsValidTemplate(ctx, msg.RejectTemplateId); err != nil { | ||
| return nil, err | ||
| } | ||
| key.RejectTemplateId = msg.RejectTemplateId | ||
| } | ||
|
|
||
| if key.ApproveRuleId != msg.ApproveRuleId { |
There was a problem hiding this comment.
Rule is still here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
warden/x/act/keeper/actions.go
Outdated
| @@ -103,6 +104,7 @@ func (k Keeper) TryRejectVotedAction(ctx context.Context, act *types.Action) err | |||
| // result in the database. | |||
| func (k Keeper) TryExecuteAction(ctx context.Context, act *types.Action) error { | |||
| ready, err := k.checkActionReady(ctx, *act) | |||
| log.Printf("\nready %v\n", ready) | |||
There was a problem hiding this comment.
It must be removed
|
Do we also need to fix
|
|
@artur-abliazimov great catch! It's not critical, but yes |
artur-abliazimov
approved these changes
Sep 12, 2024
backsapc
deleted the
feature/x-act-v2/730-3-xact-v2-rename-rule-to-template-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#730
Summary by CodeRabbit
New Features
Terminology Updates
These changes aim to enhance the expressiveness and functionality of actions within the system, making it easier for users to understand and interact with the features.