Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: unnecessary call to arweave.networkInfo when block height is requested from client #70

Closed
ppedziwiatr opened this issue Jan 1, 2022 · 2 comments
Closed

perf: unnecessary call to arweave.networkInfo when block height is requested from client #70

ppedziwiatr opened this issue Jan 1, 2022 · 2 comments
Assignees
@ppedziwiatr
Labels
performance

Comments

@ppedziwiatr
Copy link
Contributor

ppedziwiatr commented Jan 1, 2022 •
edited
Loading

calling contract.readState(txId, blockHeight) should not trigger call to arweave.networkInfo().

Also - verify how the deepCopy in https://github.com/redstone-finance/redstone-smartcontracts/blob/main/src/core/modules/impl/ContractHandlerApi.ts#L70 affects the performance - it is basically required by only one contract - ArweaveTeam/SmartWeave#92
@ppedziwiatr ppedziwiatr self-assigned this Jan 1, 2022
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
a49d27a 
…quest from client #70
@ppedziwiatr ppedziwiatr mentioned this issue Jan 3, 2022
Merged
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
a3685bb 
…quest from client #70
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
f58b651 
…quest from client #70
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
8616257 
…quest from client #70
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
936211d 
…quest from client #70
ppedziwiatr added a commit that referenced this issue Jan 3, 2022
@ppedziwiatr
perf: unnecessary call to arweave.networkInfo when block height is re…
a91f379 
…quest from client #70
@ppedziwiatr
Copy link
Contributor Author

fixed.

@ppedziwiatr
Copy link
Contributor Author

though no-one will ever use it real-life, but hey - benchmarks! ;-)

@ppedziwiatr ppedziwiatr changed the title perf: unnecessary call to arweave.networkInfo when block height is request from client perf: unnecessary call to arweave.networkInfo when block height is requested from client Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppedziwiatr ppedziwiatr

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppedziwiatr