perf: unnecessary call to arweave.networkInfo when block height is re… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedziwiatr
commented
Jan 3, 2022
ppedziwiatr
commented
Jan 3, 2022
| @@ -86,7 +86,6 @@ | |||
| "2caOW6ol9T8LHCMO8tVAx4GHRwv1q3fFc79KzKOtoww", | |||
| "HdZBZa0GfOEUYCubwvoSyxGUUgPmgy7RJb5l77T21bE", | |||
| "7Dp5r-UpZLDvHqsDbZbqWhCBwbYdJMKBuC3tFC-FF7U", | |||
| "YLVpmhSq5JmLltfg6R-5fL04rIRPrlSU22f6RQ6VyYE", | |||
There was a problem hiding this comment.
removing. Slowing down the whole SDK just because of this one, abandoned contract, is not very wise :-)
original issue: ArweaveTeam/SmartWeave#92
ppedziwiatr
force-pushed
the
ppe/perf-opt
branch
3 times, most recently
from
f58b651 to
8616257
Compare
ppedziwiatr
force-pushed
the
ppe/perf-opt
branch
from
8616257 to
a33210b
Compare
ppedziwiatr
commented
Jan 3, 2022
| @@ -49,13 +51,13 @@ describe('readState', () => { | |||
| const contractTxId = 'CbGCxBJn6jLeezqDl1w3o8oCSeRCb-MmtZNKPodla-0'; | |||
| const blockHeight = 707892; | |||
| const result = await readContract(arweave, contractTxId, blockHeight); | |||
| const resultString = JSON.stringify(result).trim(); | |||
| const resultString = stringify(result).trim(); | |||
There was a problem hiding this comment.
for the t9T7DIOGxx4VWXoCEeYYarFYeERTpWIC1V3y-BPZgKE contract the JSON.stringify turned to be non-deterministic.
ppedziwiatr
force-pushed
the
ppe/perf-opt
branch
from
f225ce1 to
6858537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…quest from client #70