Allow object-type updates with an empty relations block (#319)

warrant-dev · Apr 2, 2024 · a5af6b7 · a5af6b7
1 parent 0b7eb1b
commit a5af6b7
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/pkg/authz/objecttype/spec.go b/pkg/authz/objecttype/spec.go
@@ -62,7 +62,7 @@ func (spec CreateObjectTypeSpec) ToObjectType() (*ObjectType, error) {
 type UpdateObjectTypeSpec struct {
 	Type      string                  `json:"type"` // NOTE: used internally for updates, but value from request is ignored
 	Source    *Source                 `json:"source,omitempty"`
-	Relations map[string]RelationRule `json:"relations"        validate:"required,min=1,dive"` // NOTE: map key = name of relation
+	Relations map[string]RelationRule `json:"relations"        validate:"required,dive"` // NOTE: map key = name of relation
 }
 
 func (spec *UpdateObjectTypeSpec) ToObjectType(typeId string) (*ObjectType, error) {

diff --git a/tests/v1/object-types-crud.json b/tests/v1/object-types-crud.json
@@ -39,6 +39,24 @@
                 }
             }
         },
+        {
+            "name": "updateObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "PUT",
+                "url": "/v1/object-types/A",
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            },
+            "expectedResponse": {
+                "statusCode": 200,
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            }
+        },
         {
             "name": "deleteObjectTypeWithEmptyRelations",
             "request": {

diff --git a/tests/v2/object-types-crud.json b/tests/v2/object-types-crud.json
@@ -39,6 +39,24 @@
                 }
             }
         },
+        {
+            "name": "updateObjectTypeWithEmptyRelations",
+            "request": {
+                "method": "PUT",
+                "url": "/v2/object-types/A",
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            },
+            "expectedResponse": {
+                "statusCode": 200,
+                "body": {
+                    "type": "A",
+                    "relations": {}
+                }
+            }
+        },
         {
             "name": "deleteObjectTypeWithEmptyRelations",
             "request": {